| commit | f3b51cde98ab3ff9c0be1e38d33fae6e0770e421 | [log] [tgz] |
|---|---|---|
| author | Dan Harrington <[email protected]> | Tue Aug 28 18:00:54 2018 |
| committer | Commit Bot <[email protected]> | Tue Aug 28 18:00:54 2018 |
| tree | 4cd71a45ba8ec952a4c7e9eadfd25fa9baac2d92 | |
| parent | 21e2a0aa71d826d52c304ae83e8a321b06a4e842 [diff] |
Limit offline content suggestions to dino page Previously, offline content suggestions would show on any net error page. Now they only show on the dino page, as intended. As a beneficial side-effect, the error strings (available on page load) will indicate whether offline content may be inserted to the page later. This is important for implementing the final UI because, for instance, we need to hide error help suggestions to make room for content. I moved the feature flag from browser/ to chrome/common so that it is accessible from the error page code. This code was previously reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/1185282 and needed move to another issue for an OOO reviewer. Bug: 852872 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I86392d2b10d1f243525f043e0627b04f41f83b96 Reviewed-on: https://chromium-review.googlesource.com/1194245 Reviewed-by: Shakti Sahu <[email protected]> Reviewed-by: Matt Menke <[email protected]> Reviewed-by: Carlos Knippschild <[email protected]> Reviewed-by: Peter Lee <[email protected]> Commit-Queue: Dan H <[email protected]> Cr-Commit-Position: refs/heads/master@{#586781}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .