| commit | f478c331c5b2a59b68912e458301f12fb279be3b | [log] [tgz] |
|---|---|---|
| author | Maksim Ivanov <[email protected]> | Fri Dec 11 12:01:14 2020 |
| committer | Chromium LUCI CQ <[email protected]> | Fri Dec 11 12:01:14 2020 |
| tree | 1d59288eb870c775ef73076cae2fa5033f68cb89 | |
| parent | 320ccdbfe65dbb9491d1310bbfc03c0da76f88ca [diff] [blame] |
Fix potential use-after-move in //net/base/ Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I7b45782b6f9fed91c68cf3e989be026cadfd9d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586344 Commit-Queue: Wez <[email protected]> Auto-Submit: Maksim Ivanov <[email protected]> Reviewed-by: Wez <[email protected]> Cr-Commit-Position: refs/heads/master@{#836070}
diff --git a/net/base/network_change_notifier_fuchsia.cc b/net/base/network_change_notifier_fuchsia.cc index 3c10a11..6d7bbb05 100644 --- a/net/base/network_change_notifier_fuchsia.cc +++ b/net/base/network_change_notifier_fuchsia.cc
@@ -107,13 +107,13 @@ void NetworkChangeNotifierFuchsia::OnInterfaceAdded( fuchsia::net::interfaces::Properties properties) { + uint64_t id = properties.id(); base::Optional<internal::InterfaceProperties> cache_entry = internal::InterfaceProperties::VerifyAndCreate(std::move(properties)); if (!cache_entry) { OnWatcherError("OnInterfaceAdded: incomplete interface properties."); return; } - uint64_t id = properties.id(); if (interface_cache_.find(id) != interface_cache_.end()) { OnWatcherError(base::StringPrintf( "OnInterfaceAdded: duplicate interface ID %lu.", id));