commit f79ed40d0ed19927d312d80a4bf797ab143bc025
author treib <treib@chromium.org> Tue Sep 22 12:38:06 2015
committer Commit bot <commit-bot@chromium.org> Tue Sep 22 12:39:21 2015
tree 7355acd104e92f60f76447926bcf8c2711ade0ac
parent 30035b6683d9daad1b6a3278c96537dcfe1d4abe

Popular sites on the NTP: re-download popular suggestions once per Chrome run

BUG=516618

Review URL: https://codereview.chromium.org/1308723005

Cr-Commit-Position: refs/heads/master@{#350144}

chrome/browser/net/file_downloader.cc

diff --git a/chrome/browser/net/file_downloader.cc b/chrome/browser/net/file_downloader.cc
index d97fa272..1b5c2c2 100644
--- a/chrome/browser/net/file_downloader.cc
+++ b/chrome/browser/net/file_downloader.cc
@@ -21,6 +21,7 @@
 
 FileDownloader::FileDownloader(const GURL& url,
                                const base::FilePath& path,
+                               bool overwrite,
                                net::URLRequestContextGetter* request_context,
                                const DownloadFinishedCallback& callback)
     : callback_(callback),
@@ -34,13 +35,17 @@
       path,
       BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
 
-  base::PostTaskAndReplyWithResult(
-      BrowserThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(
-          base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN).get(),
-      FROM_HERE,
-      base::Bind(&base::PathExists, path),
-      base::Bind(&FileDownloader::OnFileExistsCheckDone,
-                 weak_ptr_factory_.GetWeakPtr()));
+  if (overwrite) {
+    fetcher_->Start();
+  } else {
+    base::PostTaskAndReplyWithResult(
+        BrowserThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(
+            base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN).get(),
+        FROM_HERE,
+        base::Bind(&base::PathExists, path),
+        base::Bind(&FileDownloader::OnFileExistsCheckDone,
+                   weak_ptr_factory_.GetWeakPtr()));
+  }
 }
 
 FileDownloader::~FileDownloader() {}
@@ -53,14 +58,16 @@
 
   const net::URLRequestStatus& status = source->GetStatus();
   if (!status.is_success()) {
-    DLOG(WARNING) << "URLRequestStatus error " << status.error();
+    DLOG(WARNING) << "URLRequestStatus error " << status.error()
+        << " while trying to download " << source->GetURL().spec();
     callback_.Run(false);
     return;
   }
 
   int response_code = source->GetResponseCode();
   if (response_code != net::HTTP_OK) {
-    DLOG(WARNING) << "HTTP error " << response_code;
+    DLOG(WARNING) << "HTTP error " << response_code
+        << " while trying to download " << source->GetURL().spec();
     callback_.Run(false);
     return;
   }