Google Git
Sign in
chromium / chromium / src.git / f7b270fdbb7fd699ca0ff1292e80ee9f94f4c11f
commitf7b270fdbb7fd699ca0ff1292e80ee9f94f4c11f[log] [tgz]
authorDavid Van Cleve <[email protected]>Tue Jun 22 13:27:19 2021
committerChromium LUCI CQ <[email protected]>Tue Jun 22 13:27:19 2021
tree4838564e293223819e517ecee71df86b36a2bc31
parent0c466221c8eb186ae910b512e8ae320a261303dc [diff]
sql: Have MetaTable expose a "delete the table" method

sql::MetaTable works by manipulating a caller-provided database to store
additional version information in a new metadata table. Some clients
using sql::MetaTable might start out with their databases unversioned
and switch to maintaining version metadata at a later time. In this
case, it can help to be able to test the no-metadata-maintained to
metadata-maintained upgrade.  However, once a database begins using a
metadata table, it might be difficult to emulate the state of the
database prior to using a metadata table. Clearing out the initialized
metadata table can achieve this effect, but the name of the metadata
table is an implementation detail, so it's not possible to just delete
the table directly from test code. To get around this issue, this CL
adds an sql::MetaTable::DeleteTableForTesting method to do just that.

As one example, the child CL crrev.com/c/2908133 uses this method to
verify its database correctly handles an upgrade from a state with no
version written to disk.

Bug: None
Change-Id: I5d440e11196638a04ad16beb4002ed5d3e25af19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2920848
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#894658}
3 files changed
tree: 4838564e293223819e517ecee71df86b36a2bc31
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.