Adding a flag for new Password Form parsing.
This flag will be used for developing new Password Manager design and
form parsing (details go/new-cpm-design-refactoring).
Bug: 831123
Change-Id: I4b1becd5d926b6d8e3d841094f793d901c7998e6
Reviewed-on: https://chromium-review.googlesource.com/1016648
Commit-Queue: Vadym Doroshenko <[email protected]>
Reviewed-by: Vaclav Brozek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#551668}diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index cc1b5fd..035ec55e 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1639,6 +1639,10 @@
flag_descriptions::kManualPasswordGenerationDescription, kOsAll,
FEATURE_VALUE_TYPE(
password_manager::features::kEnableManualPasswordGeneration)},
+ {"new-password-form-parsing",
+ flag_descriptions::kNewPasswordFormParsingName,
+ flag_descriptions::kNewPasswordFormParsingDescription, kOsAll,
+ FEATURE_VALUE_TYPE(password_manager::features::kNewPasswordFormParsing)},
{"enable-show-autofill-signatures",
flag_descriptions::kShowAutofillSignaturesName,
flag_descriptions::kShowAutofillSignaturesDescription, kOsAll,
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index ea46365b..5eb5d07 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -968,6 +968,12 @@
const char kNewBookmarkAppsDescription[] =
"Enables the new system for creating bookmark apps.";
+const char kNewPasswordFormParsingName[] = "New password form parsing";
+const char kNewPasswordFormParsingDescription[] =
+ "Replaces existing form parsing in password manager with a new version, "
+ "currently under development. WARNING: when enabled Password Manager might "
+ "stop working";
+
const char kNewRemotePlaybackPipelineName[] =
"Enable the new remote playback pipeline.";
const char kNewRemotePlaybackPipelineDescription[] =
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index cbea73da..abc5ed1 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -616,6 +616,9 @@
extern const char kNewBookmarkAppsName[];
extern const char kNewBookmarkAppsDescription[];
+extern const char kNewPasswordFormParsingName[];
+extern const char kNewPasswordFormParsingDescription[];
+
extern const char kNewRemotePlaybackPipelineName[];
extern const char kNewRemotePlaybackPipelineDescription[];
diff --git a/components/password_manager/core/common/password_manager_features.cc b/components/password_manager/core/common/password_manager_features.cc
index 19a6884..c0cde67a 100644
--- a/components/password_manager/core/common/password_manager_features.cc
+++ b/components/password_manager/core/common/password_manager_features.cc
@@ -73,6 +73,10 @@
// selection, rather than autofilling on page load, with highlighting of fields.
const base::Feature kFillOnAccountSelect = {"fill-on-account-select",
base::FEATURE_DISABLED_BY_DEFAULT};
+// Enables new password form parsing mechanism, details in
+// go/new-cpm-design-refactoring.
+const base::Feature kNewPasswordFormParsing = {
+ "new-password-form-parsing", base::FEATURE_DISABLED_BY_DEFAULT};
} // namespace features
diff --git a/components/password_manager/core/common/password_manager_features.h b/components/password_manager/core/common/password_manager_features.h
index 98ebb04..972a05b 100644
--- a/components/password_manager/core/common/password_manager_features.h
+++ b/components/password_manager/core/common/password_manager_features.h
@@ -26,6 +26,7 @@
extern const base::Feature kPasswordForceSaving;
extern const base::Feature kEnableShowAllSavedPasswordsContextMenu;
extern const base::Feature kFillOnAccountSelect;
+extern const base::Feature kNewPasswordFormParsing;
extern const base::Feature kPasswordExport;
extern const base::Feature kPasswordImport;
extern const base::Feature kPasswordSearchMobile;
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index e5882ef7..a450c070 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -26631,6 +26631,7 @@
<int value="-855130893" label="enable-touch-calibration-setting"/>
<int value="-853594220" label="disable-new-avatar-menu"/>
<int value="-848691867" label="DesktopPWAWindowing:enabled"/>
+ <int value="-847651283" label="new-password-form-parsing:disabled"/>
<int value="-847216521" label="ChromeDuplex:enabled"/>
<int value="-844537521" label="HttpFormWarning:disabled"/>
<int value="-844381918" label="ArcNativeBridgeExperiment:disabled"/>
@@ -27423,6 +27424,7 @@
<int value="1082054180" label="PersistentWindowBounds:disabled"/>
<int value="1083201516" label="PersistentWindowBounds:enabled"/>
<int value="1087235172" label="file-manager-enable-new-audio-player"/>
+ <int value="1088915385" label="new-password-form-parsing:enabled"/>
<int value="1090377940" label="enable-quic-https"/>
<int value="1092896354" label="EnableFullscreenAppList:disabled"/>
<int value="1094506652" label="UseGoogleLocalNtp:enabled"/>
