Google Git
Sign in
chromium / chromium / src.git / f8d479d433be00fe91b83f7624d1dade4d6da797
commitf8d479d433be00fe91b83f7624d1dade4d6da797[log] [tgz]
authorJan Wilken Dörrie <[email protected]>Mon Nov 23 12:21:13 2020
committerCommit Bot <[email protected]>Mon Nov 23 12:21:13 2020
tree25ec2db47d0e51524a7f0afc83e8d27c0c61ab79
parent99a42e2d128ae0993f574294cfbab2a1f1f8dad4 [diff]
Reland "[base] Add NO_UNIQUE_ADDRESS attribute"

This reverts commit d3d9bac004ab0c24623460de1da14418211adb0f.

Reason for revert: https://bugs.llvm.org/show_bug.cgi?id=48048 got fixed.

Original change's description:
> Revert "[base] Add NO_UNIQUE_ADDRESS attribute"
>
> This reverts commit d3742a4b80f2ad07fd8ccd111c67726ce9cf1c7f.
>
> Reason for revert: https://crbug.com/1144431
> Bug: 1144431
>
> Original change's description:
> > [base] Add NO_UNIQUE_ADDRESS attribute
> >
> > This change adds the HAS_CPP_ATTRIBUTE and NO_UNIQUE_ADDRESS macros to
> > base/compiler_specific.h. This allows using the C++20 no_unique_address
> > attribute in prior dialects if the compiler supports it.
> >
> > Bug: None
> > Change-Id: I6aff82e7b195f5eaf93551049c9dfa6a3fd1fbc6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510396
> > Reviewed-by: Daniel Cheng <[email protected]>
> > Commit-Queue: Jan Wilken Dörrie <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#822768}
>
> [email protected],[email protected]
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: None
> Change-Id: I375099e835dbc7d4cab98cc15faf66124335bb0e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514208
> Commit-Queue: Jan Wilken Dörrie <[email protected]>
> Reviewed-by: Jan Wilken Dörrie <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#823202}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1144431
Bug: None
Change-Id: Ieffa10dce233eb19f7dbfbcea449ea08e2f2b1cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546008
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/heads/master@{#830147}
2 files changed
tree: 25ec2db47d0e51524a7f0afc83e8d27c0c61ab79
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.