Prototype to stop more task queues.
This extends stopping to other task queues, beyond
timers and loading. This will be used to test various
breaking scenarios and edge cases.
Clean up flag structuring as part of this.
Bug:
Change-Id: I98c2a863ffb1aa5af711a026b764ba7dff928441
Reviewed-on: https://chromium-review.googlesource.com/803910
Commit-Queue: Shubhie Panicker <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#526644}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index c3f81e8..2561ffc 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -37,7 +37,6 @@
#include "chrome/common/chrome_features.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/features.h"
-#include "chrome/common/pause_tabs_field_trial.h"
#include "components/autofill/core/browser/autofill_experiments.h"
#include "components/autofill/core/common/autofill_features.h"
#include "components/autofill/core/common/autofill_switches.h"
@@ -874,35 +873,6 @@
{"Learning", kSpeculativeResourcePrefetchingLearning,
arraysize(kSpeculativeResourcePrefetchingLearning), nullptr}};
-#if defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_WIN)
-const FeatureEntry::FeatureParam kPauseBackgroundTabsMinimalEngagment[] = {
- {pausetabs::kFeatureName, pausetabs::kModeParamMinimal}};
-
-const FeatureEntry::FeatureParam kPauseBackgroundTabsLowEngagment[] = {
- {pausetabs::kFeatureName, pausetabs::kModeParamLow}};
-
-const FeatureEntry::FeatureParam kPauseBackgroundTabsMediumEngagment[] = {
- {pausetabs::kFeatureName, pausetabs::kModeParamMedium}};
-
-const FeatureEntry::FeatureParam kPauseBackgroundTabsHighEngagment[] = {
- {pausetabs::kFeatureName, pausetabs::kModeParamHigh}};
-
-const FeatureEntry::FeatureParam kPauseBackgroundTabsMaxEngagment[] = {
- {pausetabs::kFeatureName, pausetabs::kModeParamMax}};
-
-const FeatureEntry::FeatureVariation kPauseBackgroundTabsVariations[] = {
- {"minimal engagement", kPauseBackgroundTabsMinimalEngagment,
- arraysize(kPauseBackgroundTabsMinimalEngagment), nullptr},
- {"low engagement", kPauseBackgroundTabsLowEngagment,
- arraysize(kPauseBackgroundTabsLowEngagment), nullptr},
- {"medium engagement", kPauseBackgroundTabsMediumEngagment,
- arraysize(kPauseBackgroundTabsMediumEngagment), nullptr},
- {"high engagement", kPauseBackgroundTabsHighEngagment,
- arraysize(kPauseBackgroundTabsHighEngagment), nullptr},
- {"max engagement", kPauseBackgroundTabsMaxEngagment,
- arraysize(kPauseBackgroundTabsMaxEngagment), nullptr}};
-#endif
-
#if defined(OS_ANDROID)
const FeatureEntry::FeatureParam
kAutofillCreditCardPopupLayoutFeatureVariationIconAtStart[] = {
@@ -3094,14 +3064,6 @@
FEATURE_VALUE_TYPE(chrome::android::kCustomContextMenu)},
#endif // OS_ANDROID
-#if defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_WIN)
- {pausetabs::kFeatureName, flag_descriptions::kPauseBackgroundTabsName,
- flag_descriptions::kPauseBackgroundTabsDescription, kOsDesktop,
- FEATURE_WITH_PARAMS_VALUE_TYPE(pausetabs::kFeature,
- kPauseBackgroundTabsVariations,
- "PauseBackgroundTabs")},
-#endif
-
#if defined(OS_CHROMEOS)
{"ash-disable-smooth-screen-rotation",
flag_descriptions::kAshDisableSmoothScreenRotationName,
@@ -3588,6 +3550,10 @@
flag_descriptions::kStopLoadingInBackgroundDescription, kOsAndroid,
FEATURE_VALUE_TYPE(features::kStopLoadingInBackground)},
+ {"stop-in-background", flag_descriptions::kStopInBackgroundName,
+ flag_descriptions::kStopInBackgroundDescription, kOsAll,
+ FEATURE_VALUE_TYPE(features::kStopInBackground)},
+
#if defined(TOOLKIT_VIEWS)
{"experimental-tab-controller",
flag_descriptions::kExperimentalTabControllerName,