| commit | fb31b4cdff7fbde71395071d5dfb887897c8baf1 | [log] [tgz] |
|---|---|---|
| author | Xiaohan Wang <[email protected]> | Wed Jul 08 01:18:53 2020 |
| committer | Commit Bot <[email protected]> | Wed Jul 08 01:18:53 2020 |
| tree | 77731afd56791806a7a440e13f6bb70144826a47 | |
| parent | a889726fcfb6ca42ebd09151f45180a85a88f1f9 [diff] |
Update GetAddressOf() PRESUBMIT Make the message more clear about the ban of variants like ReleaseAndGetAddressOf(). Bug: 914910 Change-Id: I16fb4cb51a619aea4f414601cf10279ac482992a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271072 Commit-Queue: Xiaohan Wang <[email protected]> Commit-Queue: Robert Liao <[email protected]> Reviewed-by: Robert Liao <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/master@{#786095}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index a05a6ba..ec49d8c 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py
@@ -945,8 +945,9 @@ 'GetAddressOf', ( 'Improper use of Microsoft::WRL::ComPtr<T>::GetAddressOf() has been ', - 'implicated in a few leaks. Use operator& instead. See ', - 'http://crbug.com/914910 for more conversion guidance.' + 'implicated in a few leaks. ReleaseAndGetAddressOf() is safe but ', + 'operator& is generally recommended. So always use operator& instead. ' + 'See http://crbug.com/914910 for more conversion guidance.' ), True, (),