Google Git
Sign in
chromium / chromium / src.git / 5f81c4231365df3a604b59b5c3465c1438fb503a
commit5f81c4231365df3a604b59b5c3465c1438fb503a[log] [tgz]
authorBen Pastene <[email protected]>Wed Dec 02 22:07:56 2020
committerChromium LUCI CQ <[email protected]>Wed Dec 02 22:07:56 2020
tree3f017ac7d90d9ed9a08466c36968bc0d39b24f29
parent3e152be764a6d54d1f3790ad352935ed430a8d6d [diff]
Revert "[ShapeDetection] Host Service in utility process on CrOS"

This reverts commit e69d4103a93b2dab3444174a0b103b087c8d2ee8.

Reason for revert: GN-gen failures on chrome-branded CrOS bots
https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome
eg:
https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11420
ERROR at //content/gpu/gpu_child_thread_receiver_bindings.cc:15:11: Include not allowed.
#include "services/shape_detection/shape_detection_service.h"

Original change's description:
> [ShapeDetection] Host Service in utility process on CrOS
>
> This CL updates ShapeDetection service to be hosted in a
> utility process on ChromeOS. This is being done because
> the ShapeDetection service implementation for ChromeOS
> uses a third_party library and does not use any
> accelerated native shape detection APIs that might need
> to run in GPU process.
>
> Bug: 1093185
> Change-Id: I0042d309b6daeaa66798d25b70d5d1bba05b737b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444177
> Reviewed-by: Reilly Grant <[email protected]>
> Reviewed-by: Kinuko Yasuda <[email protected]>
> Commit-Queue: Azeem Arshad <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#832841}

[email protected],[email protected],[email protected],[email protected]

Change-Id: I278f5d33714903e4226a99e6d270cb58c12c904f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1093185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570237
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/master@{#832992}
5 files changed
tree: 3f017ac7d90d9ed9a08466c36968bc0d39b24f29
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.