Google Git
Sign in
chromium / chromium / src.git / fc87d10d2aeceed3864c3d087a8b296f4b40c110
commitfc87d10d2aeceed3864c3d087a8b296f4b40c110[log] [tgz]
authorEric Orth <[email protected]>Thu Dec 23 20:31:27 2021
committerChromium LUCI CQ <[email protected]>Thu Dec 23 20:31:27 2021
treef60925c3a884a72d8e2f1e4f8f55697879f6325e
parent32d72512d04acf62d8a9f04da711f170725e3e14 [diff]
Fixup HostResolver alias results

Remove the `ipv*_alias_name` values from HostResolverEndpointResult.
We've decided that we won't need them.

Also make some adjustments to the behavior around
ResolveHostParameters::include_canonical_name to match our needs going
forward. The parameter now always ensures the system resolver is used
(DCHECKing on cases where other parameters prevent that) and the
GetDnsAliasResults() now returns exactly the single canonical name
received from the system resolver without any modification (matching
what could currently be read from
`GetAddressResults()->GetCanonicalName()`. While theoretically a
behavior change, this shouldn't actually affect any of the current
non-test usage because the parameter is only set when the system
resolver can be used and only getting the name from GetCanonicalName().
And alias names are now always included, if known, in
GetDnsAliasResults() regardless of the parameter (as was already the
case, but now it's documented and tested as such).

Also some test cleanups to add more reliance on GetDnsAiasResults() in
anticipation of reducing alias availability in address results.

Bug: 1264933
Change-Id: Iedc5f1eaa7aa01d3a34753e1ff0687d294b2b057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346200
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Eric Orth <[email protected]>
Cr-Commit-Position: refs/heads/main@{#953923}
8 files changed
tree: f60925c3a884a72d8e2f1e4f8f55697879f6325e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.