Standardize usage of virtual/override/final in chrome/browser/net
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
[email protected]
Review URL: https://codereview.chromium.org/667143004
Cr-Commit-Position: refs/heads/master@{#300833}
diff --git a/chrome/browser/net/predictor.h b/chrome/browser/net/predictor.h
index 474976061..08ac322 100644
--- a/chrome/browser/net/predictor.h
+++ b/chrome/browser/net/predictor.h
@@ -619,18 +619,18 @@
public:
explicit SimplePredictor(bool preconnect_enabled, bool predictor_enabled)
: Predictor(preconnect_enabled, predictor_enabled) {}
- virtual ~SimplePredictor() {}
- virtual void InitNetworkPredictor(
- PrefService* user_prefs,
- PrefService* local_state,
- IOThread* io_thread,
- net::URLRequestContextGetter* getter,
- ProfileIOData* profile_io_data) override;
- virtual void ShutdownOnUIThread() override;
+ ~SimplePredictor() override {}
+ void InitNetworkPredictor(PrefService* user_prefs,
+ PrefService* local_state,
+ IOThread* io_thread,
+ net::URLRequestContextGetter* getter,
+ ProfileIOData* profile_io_data) override;
+ void ShutdownOnUIThread() override;
+
private:
// These member functions return True for unittests.
- virtual bool CanPrefetchAndPrerender() const override;
- virtual bool CanPreresolveAndPreconnect() const override;
+ bool CanPrefetchAndPrerender() const override;
+ bool CanPreresolveAndPreconnect() const override;
};
} // namespace chrome_browser_net
