Part 2 of search provider refactoring.
Moves field_trial_triggered_ and field_trial_triggered_in_session_
fields to base_search_provider. Moves shared AddProviderInfo and
field_trial_triggered_in_session methods using those fields into the
superclass.
BUG=338955
[email protected]
Review URL: https://codereview.chromium.org/143263019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249587 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/autocomplete/search_provider.cc b/chrome/browser/autocomplete/search_provider.cc
index c701bb8..039edbf 100644
--- a/chrome/browser/autocomplete/search_provider.cc
+++ b/chrome/browser/autocomplete/search_provider.cc
@@ -218,9 +218,7 @@
Profile* profile)
: BaseSearchProvider(listener, profile, AutocompleteProvider::TYPE_SEARCH),
providers_(TemplateURLServiceFactory::GetForProfile(profile)),
- suggest_results_pending_(0),
- field_trial_triggered_(false),
- field_trial_triggered_in_session_(false) {
+ suggest_results_pending_(0) {
}
// static
@@ -297,23 +295,6 @@
return match.GetAdditionalInfo(kSuggestMetadataKey);
}
-void SearchProvider::AddProviderInfo(ProvidersInfo* provider_info) const {
- provider_info->push_back(metrics::OmniboxEventProto_ProviderInfo());
- metrics::OmniboxEventProto_ProviderInfo& new_entry = provider_info->back();
- new_entry.set_provider(AsOmniboxEventProviderType());
- new_entry.set_provider_done(done_);
- std::vector<uint32> field_trial_hashes;
- OmniboxFieldTrial::GetActiveSuggestFieldTrialHashes(&field_trial_hashes);
- for (size_t i = 0; i < field_trial_hashes.size(); ++i) {
- if (field_trial_triggered_)
- new_entry.mutable_field_trial_triggered()->Add(field_trial_hashes[i]);
- if (field_trial_triggered_in_session_) {
- new_entry.mutable_field_trial_triggered_in_session()->Add(
- field_trial_hashes[i]);
- }
- }
-}
-
void SearchProvider::DeleteMatch(const AutocompleteMatch& match) {
DCHECK(match.deletable);
