Google Git
Sign in
chromium / chromium / src.git / fecb7543cd8c2a2ec0b39ff2eca8f3ab9717e44d
commitfecb7543cd8c2a2ec0b39ff2eca8f3ab9717e44d[log] [tgz]
authorJialiu Lin <[email protected]>Tue Nov 07 19:14:59 2017
committerCommit Bot <[email protected]>Tue Nov 07 19:14:59 2017
treea5b1b92f038d0f4bcff6a6b843bd25737db033c1
parent060dd71c370d5a145c8a57e9033811829da6b4a3 [diff]
Show change password card on already opened chrome://settings page

If user has chrome://settings already opened in some tabs, and
encountered a password reuse warning, the change password setting
card should show on these already opened chrome://settings page
as soon as the password reuse modal warning is shown.

Other fixes include: (1) exit fullscreen when warning is shown;
(2) add js tests in 
chrome/test/data/webui/settings/change_password_page_test.js
(3) minor refactoring in PasswordProtectionService.

Bug: 765740,773537
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4372b6448cc5a612a9866b1f94692eeb0cfd56e7
Reviewed-on: https://chromium-review.googlesource.com/753986
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Reviewed-by: Nathan Parker <[email protected]>
Commit-Queue: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#514530}
12 files changed
tree: a5b1b92f038d0f4bcff6a6b843bd25737db033c1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .