[email protected] | 55ad8c1 | 2014-01-17 18:24:33 | [diff] [blame] | 1 | // Copyright 2014 The Chromium Authors. All rights reserved. |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
[email protected] | 55ad8c1 | 2014-01-17 18:24:33 | [diff] [blame] | 5 | #include "ash/screen_util.h" |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 6 | |
Ahmed Fakhry | 5d73bdf7 | 2019-02-27 18:21:07 | [diff] [blame] | 7 | #include <memory> |
| 8 | |
| 9 | #include "ash/magnifier/docked_magnifier_controller.h" |
Ahmed Fakhry | 1ac713b | 2018-11-06 18:57:46 | [diff] [blame] | 10 | #include "ash/root_window_controller.h" |
| 11 | #include "ash/shelf/shelf.h" |
Manu Cornet | a76b6b0 | 2018-08-30 21:02:23 | [diff] [blame] | 12 | #include "ash/shelf/shelf_constants.h" |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 13 | #include "ash/shell.h" |
estade | a23d6ceb | 2017-02-15 00:47:09 | [diff] [blame] | 14 | #include "ash/test/ash_test_base.h" |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 15 | #include "ash/wm/window_util.h" |
Ahmed Fakhry | 5d73bdf7 | 2019-02-27 18:21:07 | [diff] [blame] | 16 | #include "ash/wm/wm_event.h" |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 17 | #include "ui/aura/env.h" |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 18 | #include "ui/aura/window.h" |
[email protected] | fcc51c95 | 2014-02-21 21:31:26 | [diff] [blame] | 19 | #include "ui/aura/window_event_dispatcher.h" |
rjkroege | 72f8154f | 2016-10-29 00:49:02 | [diff] [blame] | 20 | #include "ui/display/manager/display_manager.h" |
Ahmed Fakhry | 4f8e372 | 2017-10-31 21:01:58 | [diff] [blame] | 21 | #include "ui/display/unified_desktop_utils.h" |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 22 | #include "ui/views/widget/widget.h" |
| 23 | #include "ui/views/widget/widget_delegate.h" |
yhanada | 698af19 | 2017-02-23 10:57:07 | [diff] [blame] | 24 | #include "ui/wm/core/coordinate_conversion.h" |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 25 | |
| 26 | namespace ash { |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 27 | |
estade | a23d6ceb | 2017-02-15 00:47:09 | [diff] [blame] | 28 | using ScreenUtilTest = AshTestBase; |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 29 | |
estade | a23d6ceb | 2017-02-15 00:47:09 | [diff] [blame] | 30 | TEST_F(ScreenUtilTest, Bounds) { |
[email protected] | f634dd3 | 2012-07-23 22:49:07 | [diff] [blame] | 31 | UpdateDisplay("600x600,500x500"); |
[email protected] | a2e6af1 | 2013-01-07 21:40:35 | [diff] [blame] | 32 | views::Widget* primary = views::Widget::CreateWindowWithContextAndBounds( |
| 33 | NULL, CurrentContext(), gfx::Rect(10, 10, 100, 100)); |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 34 | primary->Show(); |
[email protected] | a2e6af1 | 2013-01-07 21:40:35 | [diff] [blame] | 35 | views::Widget* secondary = views::Widget::CreateWindowWithContextAndBounds( |
| 36 | NULL, CurrentContext(), gfx::Rect(610, 10, 100, 100)); |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 37 | secondary->Show(); |
| 38 | |
Manu Cornet | a76b6b0 | 2018-08-30 21:02:23 | [diff] [blame] | 39 | // Maximized bounds. |
| 40 | const int bottom_inset_first = 600 - ShelfConstants::shelf_size(); |
| 41 | const int bottom_inset_second = 500 - ShelfConstants::shelf_size(); |
tdanderson | 0b7905b | 2016-06-22 21:53:03 | [diff] [blame] | 42 | EXPECT_EQ( |
Manu Cornet | a76b6b0 | 2018-08-30 21:02:23 | [diff] [blame] | 43 | gfx::Rect(0, 0, 600, bottom_inset_first).ToString(), |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 44 | screen_util::GetMaximizedWindowBoundsInParent(primary->GetNativeView()) |
tdanderson | 0b7905b | 2016-06-22 21:53:03 | [diff] [blame] | 45 | .ToString()); |
| 46 | EXPECT_EQ( |
Manu Cornet | a76b6b0 | 2018-08-30 21:02:23 | [diff] [blame] | 47 | gfx::Rect(0, 0, 500, bottom_inset_second).ToString(), |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 48 | screen_util::GetMaximizedWindowBoundsInParent(secondary->GetNativeView()) |
tdanderson | 0b7905b | 2016-06-22 21:53:03 | [diff] [blame] | 49 | .ToString()); |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 50 | |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 51 | // Display bounds |
| 52 | EXPECT_EQ("0,0 600x600", |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 53 | screen_util::GetDisplayBoundsInParent(primary->GetNativeView()) |
jamescook | b8dcef52 | 2016-06-25 14:42:55 | [diff] [blame] | 54 | .ToString()); |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 55 | EXPECT_EQ("0,0 500x500", |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 56 | screen_util::GetDisplayBoundsInParent(secondary->GetNativeView()) |
jamescook | b8dcef52 | 2016-06-25 14:42:55 | [diff] [blame] | 57 | .ToString()); |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 58 | |
| 59 | // Work area bounds |
tdanderson | 0b7905b | 2016-06-22 21:53:03 | [diff] [blame] | 60 | EXPECT_EQ( |
Manu Cornet | a76b6b0 | 2018-08-30 21:02:23 | [diff] [blame] | 61 | gfx::Rect(0, 0, 600, bottom_inset_first).ToString(), |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 62 | screen_util::GetDisplayWorkAreaBoundsInParent(primary->GetNativeView()) |
tdanderson | 0b7905b | 2016-06-22 21:53:03 | [diff] [blame] | 63 | .ToString()); |
| 64 | EXPECT_EQ( |
Manu Cornet | a76b6b0 | 2018-08-30 21:02:23 | [diff] [blame] | 65 | gfx::Rect(0, 0, 500, bottom_inset_second).ToString(), |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 66 | screen_util::GetDisplayWorkAreaBoundsInParent(secondary->GetNativeView()) |
tdanderson | 0b7905b | 2016-06-22 21:53:03 | [diff] [blame] | 67 | .ToString()); |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 68 | } |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 69 | |
[email protected] | 805155f | 2013-04-10 02:11:20 | [diff] [blame] | 70 | // Test verifies a stable handling of secondary screen widget changes |
| 71 | // (crbug.com/226132). |
estade | a23d6ceb | 2017-02-15 00:47:09 | [diff] [blame] | 72 | TEST_F(ScreenUtilTest, StabilityTest) { |
[email protected] | 805155f | 2013-04-10 02:11:20 | [diff] [blame] | 73 | UpdateDisplay("600x600,500x500"); |
| 74 | views::Widget* secondary = views::Widget::CreateWindowWithContextAndBounds( |
| 75 | NULL, CurrentContext(), gfx::Rect(610, 10, 100, 100)); |
| 76 | EXPECT_EQ(Shell::GetAllRootWindows()[1], |
jamescook | b8dcef52 | 2016-06-25 14:42:55 | [diff] [blame] | 77 | secondary->GetNativeView()->GetRootWindow()); |
[email protected] | 805155f | 2013-04-10 02:11:20 | [diff] [blame] | 78 | secondary->Show(); |
| 79 | secondary->Maximize(); |
| 80 | secondary->Show(); |
| 81 | secondary->SetFullscreen(true); |
| 82 | secondary->Hide(); |
| 83 | secondary->Close(); |
| 84 | } |
| 85 | |
estade | a23d6ceb | 2017-02-15 00:47:09 | [diff] [blame] | 86 | TEST_F(ScreenUtilTest, ConvertRect) { |
[email protected] | f634dd3 | 2012-07-23 22:49:07 | [diff] [blame] | 87 | UpdateDisplay("600x600,500x500"); |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 88 | |
[email protected] | a2e6af1 | 2013-01-07 21:40:35 | [diff] [blame] | 89 | views::Widget* primary = views::Widget::CreateWindowWithContextAndBounds( |
| 90 | NULL, CurrentContext(), gfx::Rect(10, 10, 100, 100)); |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 91 | primary->Show(); |
[email protected] | a2e6af1 | 2013-01-07 21:40:35 | [diff] [blame] | 92 | views::Widget* secondary = views::Widget::CreateWindowWithContextAndBounds( |
| 93 | NULL, CurrentContext(), gfx::Rect(610, 10, 100, 100)); |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 94 | secondary->Show(); |
| 95 | |
yhanada | 698af19 | 2017-02-23 10:57:07 | [diff] [blame] | 96 | gfx::Rect r1(10, 10, 100, 100); |
| 97 | ::wm::ConvertRectFromScreen(primary->GetNativeView(), &r1); |
| 98 | EXPECT_EQ("0,0 100x100", r1.ToString()); |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 99 | |
yhanada | 698af19 | 2017-02-23 10:57:07 | [diff] [blame] | 100 | gfx::Rect r2(620, 20, 100, 100); |
| 101 | ::wm::ConvertRectFromScreen(secondary->GetNativeView(), &r2); |
| 102 | EXPECT_EQ("10,10 100x100", r2.ToString()); |
| 103 | |
| 104 | gfx::Rect r3(30, 30, 100, 100); |
| 105 | ::wm::ConvertRectToScreen(primary->GetNativeView(), &r3); |
| 106 | EXPECT_EQ("40,40 100x100", r3.ToString()); |
| 107 | |
| 108 | gfx::Rect r4(40, 40, 100, 100); |
| 109 | ::wm::ConvertRectToScreen(secondary->GetNativeView(), &r4); |
| 110 | EXPECT_EQ("650,50 100x100", r4.ToString()); |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 111 | } |
| 112 | |
estade | a23d6ceb | 2017-02-15 00:47:09 | [diff] [blame] | 113 | TEST_F(ScreenUtilTest, ShelfDisplayBoundsInUnifiedDesktop) { |
rjkroege | 72f8154f | 2016-10-29 00:49:02 | [diff] [blame] | 114 | display_manager()->SetUnifiedDesktopEnabled(true); |
oshima | 96f6a50 | 2015-05-02 08:43:32 | [diff] [blame] | 115 | |
| 116 | views::Widget* widget = views::Widget::CreateWindowWithContextAndBounds( |
| 117 | NULL, CurrentContext(), gfx::Rect(10, 10, 100, 100)); |
sky | 00f0b89 | 2017-05-05 17:06:24 | [diff] [blame] | 118 | aura::Window* window = widget->GetNativeWindow(); |
oshima | 96f6a50 | 2015-05-02 08:43:32 | [diff] [blame] | 119 | |
| 120 | UpdateDisplay("500x400"); |
sky | 00f0b89 | 2017-05-05 17:06:24 | [diff] [blame] | 121 | EXPECT_EQ("0,0 500x400", |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 122 | screen_util::GetDisplayBoundsWithShelf(window).ToString()); |
oshima | 96f6a50 | 2015-05-02 08:43:32 | [diff] [blame] | 123 | |
| 124 | UpdateDisplay("500x400,600x400"); |
sky | 00f0b89 | 2017-05-05 17:06:24 | [diff] [blame] | 125 | EXPECT_EQ("0,0 500x400", |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 126 | screen_util::GetDisplayBoundsWithShelf(window).ToString()); |
oshima | 96f6a50 | 2015-05-02 08:43:32 | [diff] [blame] | 127 | |
| 128 | // Move to the 2nd physical display. Shelf's display still should be |
| 129 | // the first. |
| 130 | widget->SetBounds(gfx::Rect(800, 0, 100, 100)); |
| 131 | ASSERT_EQ("800,0 100x100", widget->GetWindowBoundsInScreen().ToString()); |
| 132 | |
sky | 00f0b89 | 2017-05-05 17:06:24 | [diff] [blame] | 133 | EXPECT_EQ("0,0 500x400", |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 134 | screen_util::GetDisplayBoundsWithShelf(window).ToString()); |
oshima | 96f6a50 | 2015-05-02 08:43:32 | [diff] [blame] | 135 | |
| 136 | UpdateDisplay("600x500"); |
sky | 00f0b89 | 2017-05-05 17:06:24 | [diff] [blame] | 137 | EXPECT_EQ("0,0 600x500", |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 138 | screen_util::GetDisplayBoundsWithShelf(window).ToString()); |
oshima | 96f6a50 | 2015-05-02 08:43:32 | [diff] [blame] | 139 | } |
| 140 | |
Ahmed Fakhry | 4f8e372 | 2017-10-31 21:01:58 | [diff] [blame] | 141 | TEST_F(ScreenUtilTest, ShelfDisplayBoundsInUnifiedDesktopGrid) { |
Ahmed Fakhry | 4f8e372 | 2017-10-31 21:01:58 | [diff] [blame] | 142 | UpdateDisplay("500x400,400x600,300x600,200x300,600x200,350x400"); |
| 143 | display_manager()->SetUnifiedDesktopEnabled(true); |
| 144 | |
| 145 | views::Widget* widget = views::Widget::CreateWindowWithContextAndBounds( |
| 146 | NULL, CurrentContext(), gfx::Rect(10, 10, 100, 100)); |
| 147 | aura::Window* window = widget->GetNativeWindow(); |
| 148 | |
| 149 | display::DisplayIdList list = display_manager()->GetCurrentDisplayIdList(); |
| 150 | ASSERT_EQ(6u, list.size()); |
| 151 | // Create a 3 x 2 vertical layout matrix and set it. |
| 152 | // [500 x 400] [400 x 600] |
| 153 | // [300 x 600] [200 x 300] |
| 154 | // [600 x 200] [350 x 400] |
| 155 | display::UnifiedDesktopLayoutMatrix matrix; |
| 156 | matrix.resize(3u); |
| 157 | matrix[0].emplace_back(list[0]); |
| 158 | matrix[0].emplace_back(list[1]); |
| 159 | matrix[1].emplace_back(list[2]); |
| 160 | matrix[1].emplace_back(list[3]); |
| 161 | matrix[2].emplace_back(list[4]); |
| 162 | matrix[2].emplace_back(list[5]); |
| 163 | display_manager()->SetUnifiedDesktopMatrix(matrix); |
| 164 | display::Screen* screen = display::Screen::GetScreen(); |
| 165 | EXPECT_EQ(gfx::Size(766, 1254), screen->GetPrimaryDisplay().size()); |
| 166 | |
Ahmed Fakhry | 1ac713b | 2018-11-06 18:57:46 | [diff] [blame] | 167 | Shelf* shelf = Shell::GetPrimaryRootWindowController()->shelf(); |
| 168 | EXPECT_EQ(shelf->alignment(), SHELF_ALIGNMENT_BOTTOM); |
| 169 | |
| 170 | // Regardless of where the window is, the shelf with a bottom alignment is |
| 171 | // always in the bottom left display in the matrix. |
| 172 | EXPECT_EQ(gfx::Rect(0, 1057, 593, 198), |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 173 | screen_util::GetDisplayBoundsWithShelf(window)); |
Ahmed Fakhry | 4f8e372 | 2017-10-31 21:01:58 | [diff] [blame] | 174 | |
| 175 | // Move to the bottom right display. |
| 176 | widget->SetBounds(gfx::Rect(620, 940, 100, 100)); |
Ahmed Fakhry | 1ac713b | 2018-11-06 18:57:46 | [diff] [blame] | 177 | EXPECT_EQ(gfx::Rect(0, 1057, 593, 198), |
| 178 | screen_util::GetDisplayBoundsWithShelf(window)); |
| 179 | |
| 180 | // Change the shelf alignment to left, and expect that it now resides in the |
| 181 | // top left display in the matrix. |
| 182 | shelf->SetAlignment(SHELF_ALIGNMENT_LEFT); |
Ahmed Fakhry | 4f8e372 | 2017-10-31 21:01:58 | [diff] [blame] | 183 | EXPECT_EQ(gfx::Rect(0, 0, 499, 400), |
Qiang Xu | 07d7c9e3 | 2018-01-18 20:25:44 | [diff] [blame] | 184 | screen_util::GetDisplayBoundsWithShelf(window)); |
Ahmed Fakhry | 1ac713b | 2018-11-06 18:57:46 | [diff] [blame] | 185 | |
| 186 | // Change the shelf alignment to right, and expect that it now resides in the |
| 187 | // top right display in the matrix. |
| 188 | shelf->SetAlignment(SHELF_ALIGNMENT_RIGHT); |
| 189 | EXPECT_EQ(gfx::Rect(499, 0, 267, 400), |
| 190 | screen_util::GetDisplayBoundsWithShelf(window)); |
| 191 | |
| 192 | // Change alignment back to bottom and change the unified display zoom factor. |
| 193 | // Expect that the display with shelf bounds will take into account the zoom |
| 194 | // factor. |
| 195 | shelf->SetAlignment(SHELF_ALIGNMENT_BOTTOM); |
| 196 | display_manager()->UpdateZoomFactor(display::kUnifiedDisplayId, 3.f); |
| 197 | const display::Display unified_display = |
| 198 | display_manager()->GetDisplayForId(display::kUnifiedDisplayId); |
| 199 | EXPECT_FLOAT_EQ(unified_display.device_scale_factor(), 3.f); |
| 200 | EXPECT_EQ(gfx::Rect(0, 352, 198, 67), |
| 201 | screen_util::GetDisplayBoundsWithShelf(window)); |
Ahmed Fakhry | 4f8e372 | 2017-10-31 21:01:58 | [diff] [blame] | 202 | } |
| 203 | |
Malay Keshav | fd6fd0c | 2018-07-31 22:07:47 | [diff] [blame] | 204 | TEST_F(ScreenUtilTest, SnapBoundsToDisplayEdge) { |
| 205 | UpdateDisplay("2400x1600*1.5"); |
| 206 | |
| 207 | gfx::Rect bounds(1555, 0, 45, 1066); |
| 208 | views::Widget* widget = views::Widget::CreateWindowWithContextAndBounds( |
| 209 | NULL, CurrentContext(), bounds); |
| 210 | aura::Window* window = widget->GetNativeWindow(); |
| 211 | |
| 212 | gfx::Rect snapped_bounds = |
| 213 | screen_util::SnapBoundsToDisplayEdge(bounds, window); |
| 214 | |
| 215 | EXPECT_EQ(snapped_bounds, gfx::Rect(1555, 0, 45, 1067)); |
| 216 | |
| 217 | bounds = gfx::Rect(5, 1000, 1595, 66); |
| 218 | snapped_bounds = screen_util::SnapBoundsToDisplayEdge(bounds, window); |
| 219 | EXPECT_EQ(snapped_bounds, gfx::Rect(5, 1000, 1595, 67)); |
| 220 | |
| 221 | UpdateDisplay("800x600"); |
| 222 | bounds = gfx::Rect(0, 552, 800, 48); |
| 223 | snapped_bounds = screen_util::SnapBoundsToDisplayEdge(bounds, window); |
| 224 | EXPECT_EQ(snapped_bounds, gfx::Rect(0, 552, 800, 48)); |
| 225 | } |
| 226 | |
Ahmed Fakhry | 5d73bdf7 | 2019-02-27 18:21:07 | [diff] [blame] | 227 | // Tests that making a window fullscreen while the Docked Magnifier is enabled |
| 228 | // won't make its bounds occupy the entire screen bounds, but will take into |
| 229 | // account the Docked Magnifier height. |
| 230 | TEST_F(ScreenUtilTest, FullscreenWindowBoundsWithDockedMagnifier) { |
| 231 | UpdateDisplay("1366x768"); |
| 232 | |
| 233 | std::unique_ptr<aura::Window> window = CreateToplevelTestWindow( |
| 234 | gfx::Rect(300, 300, 200, 150), kShellWindowId_DefaultContainer); |
| 235 | |
| 236 | auto* docked_magnifier_controller = |
| 237 | Shell::Get()->docked_magnifier_controller(); |
| 238 | docked_magnifier_controller->SetEnabled(true); |
| 239 | |
| 240 | const wm::WMEvent event(wm::WM_EVENT_TOGGLE_FULLSCREEN); |
| 241 | wm::GetWindowState(window.get())->OnWMEvent(&event); |
| 242 | |
| 243 | constexpr gfx::Rect kDisplayBounds{1366, 768}; |
| 244 | EXPECT_NE(window->bounds(), kDisplayBounds); |
| 245 | |
| 246 | gfx::Rect expected_bounds = kDisplayBounds; |
| 247 | expected_bounds.Inset( |
| 248 | 0, docked_magnifier_controller->GetTotalMagnifierHeight(), 0, 0); |
| 249 | EXPECT_EQ(expected_bounds, window->bounds()); |
| 250 | } |
| 251 | |
[email protected] | 8d625fb | 2012-07-18 16:40:06 | [diff] [blame] | 252 | } // namespace ash |