| commit | 0074e68fe67b33eaf1cf55a6c59e1bdb798c2600 | [log] [tgz] |
|---|---|---|
| author | Ben Goldberger <[email protected]> | Wed Sep 09 17:09:09 2020 |
| committer | Commit Bot <[email protected]> | Wed Sep 09 17:09:09 2020 |
| tree | 40646fc60c79b3f74bc94c6a8acc6966c8031d4e | |
| parent | 1c3c18d5e08b8ae59196f79ea2eed61ce280cd2b [diff] [blame] |
Lens Shopping chip implementation for context menu Dark Mode single line: https://drive.google.com/file/d/1_sK8UZ3bXhQjsvpFEWGfzB1d4A105M3t/view Light Mode multi-line: https://drive.google.com/file/d/16uwoOIRa7jAv08KTMNKcmE4qbDoH79NE/view There are still a few bugs which will need to be fixed in a follow up: 1. Multiline text hides the close button and doesn't have correct alignment/padding 2. Dark color mode should match context menu color (adaptive color needs to be added for this case). Change-Id: Id9196815d4e9539a53c0e01aa52e104be28b9b99 Bug: 1099982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340007 Commit-Queue: Ben Goldberger <[email protected]> Reviewed-by: Theresa <[email protected]> Reviewed-by: Sinan Sahin <[email protected]> Cr-Commit-Position: refs/heads/master@{#805370}
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc index e4f4cf8..9f663f6 100644 --- a/chrome/browser/flag_descriptions.cc +++ b/chrome/browser/flag_descriptions.cc
@@ -349,6 +349,12 @@ "eligibility requirements for showing app banners, such as having a " "manifest, are met."; +const char kContextMenuGoogleLensChipName[] = + "Google Lens powered image search for surfaced as a chip below the context " + "menu."; +const char kContextMenuGoogleLensChipDescription[] = + "Enable a chip for a Shopping intent into Google Lens when supported. "; + const char kContextMenuSearchWithGoogleLensName[] = "Google Lens powered image search in the context menu."; const char kContextMenuSearchWithGoogleLensDescription[] =