Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/net/cookies/parsed_cookie_unittest.cc b/net/cookies/parsed_cookie_unittest.cc
index 37296502..57de115 100644
--- a/net/cookies/parsed_cookie_unittest.cc
+++ b/net/cookies/parsed_cookie_unittest.cc
@@ -208,7 +208,7 @@
}
TEST(ParsedCookieTest, InvalidEmpty) {
- ParsedCookie pc("");
+ ParsedCookie pc((std::string()));
EXPECT_FALSE(pc.IsValid());
}
@@ -259,7 +259,7 @@
TEST(ParsedCookieTest, SetNameAndValue) {
- ParsedCookie empty("");
+ ParsedCookie empty((std::string()));
EXPECT_FALSE(empty.IsValid());
EXPECT_FALSE(empty.SetDomain("foobar.com"));
EXPECT_TRUE(empty.SetName("name"));
@@ -282,7 +282,7 @@
EXPECT_EQ("name=value", pc.ToCookieLine());
EXPECT_TRUE(pc.IsValid());
- EXPECT_FALSE(pc.SetName(""));
+ EXPECT_FALSE(pc.SetName(std::string()));
EXPECT_EQ("name=value", pc.ToCookieLine());
EXPECT_TRUE(pc.IsValid());
@@ -303,7 +303,7 @@
EXPECT_EQ("test=\"foobar\"", pc.ToCookieLine());
EXPECT_TRUE(pc.IsValid());
- EXPECT_TRUE(pc.SetValue(""));
+ EXPECT_TRUE(pc.SetValue(std::string()));
EXPECT_EQ("test=", pc.ToCookieLine());
EXPECT_TRUE(pc.IsValid());
}
@@ -313,7 +313,7 @@
EXPECT_TRUE(pc.IsValid());
// Clear an unset attribute.
- EXPECT_TRUE(pc.SetDomain(""));
+ EXPECT_TRUE(pc.SetDomain(std::string()));
EXPECT_FALSE(pc.HasDomain());
EXPECT_EQ("name=value", pc.ToCookieLine());
EXPECT_TRUE(pc.IsValid());
@@ -355,10 +355,10 @@
pc.ToCookieLine());
// Clear the rest and change the name and value.
- EXPECT_TRUE(pc.SetDomain(""));
- EXPECT_TRUE(pc.SetPath(""));
- EXPECT_TRUE(pc.SetExpires(""));
- EXPECT_TRUE(pc.SetMaxAge(""));
+ EXPECT_TRUE(pc.SetDomain(std::string()));
+ EXPECT_TRUE(pc.SetPath(std::string()));
+ EXPECT_TRUE(pc.SetExpires(std::string()));
+ EXPECT_TRUE(pc.SetMaxAge(std::string()));
EXPECT_TRUE(pc.SetIsSecure(false));
EXPECT_TRUE(pc.SetIsHttpOnly(false));
EXPECT_TRUE(pc.SetName("name2"));
