Google Git
Sign in
chromium / chromium / src / 6fdfea114478a5acf0d1319d39903670960a6bbc
commit6fdfea114478a5acf0d1319d39903670960a6bbc[log] [tgz]
authorWill Harris <[email protected]>Thu Jul 16 21:41:47 2020
committerCommit Bot <[email protected]>Thu Jul 16 21:41:47 2020
tree09b9793f1c14a10eee63cdc598af09affe185e52
parentdda5ff141b06cdd0028516eaad0cfba9b29f070f [diff]
Turn on CFG linker config and bitmap generation for DLLs.

Before this CL, only EXE files had CFG bitmap generated
and PE DLL Characteristics "Control Flow Guard" enabled.

This CL enables these for DLLs as well. It is a no-op for
Chrome code as the dispatch guards are not being generated
but will protect indirect calls from e.g. system libraries
from being able to call into arbitrary Chrome code.

This CL also updates checkbins.py to ensure that shipped
binaries always have /guard:CF enabled, and also enables
longjmp support as compiler issues were isolated to MSVC
which we no longer use.

See Comment 30 on bug for size impact analysis.

TEST=Verify by running dumpbin.exe on Chrome DLLs and
checking for "Control Flow Guard" in the "DLL characteristics"
header field, or run tools/checkbins/checkbins.py on
output directory.

BUG=584575

Cq-Include-Trybots: luci.chromium.try:win7-rel,win_archive,win_x64_archive
Change-Id: I4b78b97e93cd81dee70d0b3d1edd3d8e522a5495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298284
Commit-Queue: Will Harris <[email protected]>
Reviewed-by: Bruce Dawson <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Scott Graham <[email protected]>
Cr-Commit-Position: refs/heads/master@{#789208}
3 files changed
tree: 09b9793f1c14a10eee63cdc598af09affe185e52
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.