Revert 51231 - Loosen permission on extension temp dir when a flag is used.
Issue 35198 can not be reproduced locally. To enable users to do experiments, three command line flags are added to chrome:
--issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped.
--issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process.
--issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory.
BUG=35198
TEST=manual
Review URL: http://codereview.chromium.org/2802018
[email protected]
Review URL: http://codereview.chromium.org/2861039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51238 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/base/file_util_posix.cc b/base/file_util_posix.cc
index e868a41..9d738da0 100644
--- a/base/file_util_posix.cc
+++ b/base/file_util_posix.cc
@@ -428,15 +428,7 @@
bool CreateTemporaryDirInDir(const FilePath& base_dir,
const FilePath::StringType& prefix,
- FilePath* new_dir,
- bool loosen_permissions) {
- // To understand crbug/35198, the ability to call this
- // this function on windows while giving loose permissions
- // to the resulting directory has been temporarily added.
- // It should not be posible to call this function with
- // loosen_permissions == true on non-windows plarforms.
- CHECK(!loosen_permissions);
-
+ FilePath* new_dir) {
FilePath::StringType mkdtemp_template = prefix;
mkdtemp_template.append(FILE_PATH_LITERAL("XXXXXX"));
return CreateTemporaryDirInDirImpl(base_dir, mkdtemp_template, new_dir);
