Google Git
Sign in
chromium / chromium / src / 0476932294da8809a19189b9f54cee11d50cc512
commit0476932294da8809a19189b9f54cee11d50cc512[log] [tgz]
authorSylvain Defresne <[email protected]>Tue Oct 29 10:09:27 2019
committerCommit Bot <[email protected]>Tue Oct 29 10:09:27 2019
tree1a0da35269902d06fcb7a74dda4529bd18c0604b
parentdd4c907b0f8599c789bca5a605a9af73c519a9a5 [diff]
Fix layering violation in //components/translate/ios/browser

As documented in //components/README.md, code in components must not
depend on higher-level layers of the Chromium codebase, including
//ios/chrome.

Move ukm_url_recorder.* and tests from ios/chrome/browser/metrics to
components/ukm/ios (to parallel the version in content that is found
in components/ukm/content).

Fix UkmUrlRecorderTest to use WebTestWithWebState instead of the
unavailable (due to layering violation) ChromeWebTest.

Bug: 754895
Change-Id: I829486037063f16fe5fca5b7617017c0530a1859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878649
Auto-Submit: Sylvain Defresne <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#710273}
21 files changed
tree: 1a0da35269902d06fcb7a74dda4529bd18c0604b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .