Move ExtensionMsg_ExecuteCode_Params to mojo
This CL moves ExtensionMsg_ExecuteCode_Params to
extensions::mojom::ExecuteCodeParams.
It temporarily adds extension_messages_param_traits.{cc,h} for
sending the mojom type to legacy IPCs. Once
ExtensionMsg_ExecuteCode is converted to mojo, the traits will be
cleaned up.
Bug: 1180858
Change-Id: I634926d464811230a41b6eaff45a7e1ebc8aa2c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2748255
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Commit-Queue: Julie Kim <[email protected]>
Cr-Commit-Position: refs/heads/master@{#861843}
diff --git a/extensions/browser/script_executor.h b/extensions/browser/script_executor.h
index 2abf990..0ad4f85 100644
--- a/extensions/browser/script_executor.h
+++ b/extensions/browser/script_executor.h
@@ -20,7 +20,6 @@
#include "extensions/common/user_script.h"
class GURL;
-struct ExtensionMsg_ExecuteCode_Params;
namespace content {
class WebContents;
@@ -40,7 +39,7 @@
void(content::WebContents*, const ExecutingScriptsMap&, const GURL&)>;
// Interface for executing extension content scripts (e.g. executeScript) as
-// described by the ExtensionMsg_ExecuteCode_Params IPC, and notifying the
+// described by the mojom::ExecuteCodeParams IPC, and notifying the
// caller when responded with ExtensionHostMsg_ExecuteCodeFinished.
class ScriptExecutor {
public:
@@ -97,8 +96,8 @@
using ScriptFinishedCallback =
base::OnceCallback<void(std::vector<FrameResult> frame_results)>;
- // Executes a script. The arguments match ExtensionMsg_ExecuteCode_Params in
- // extension_messages.h (request_id is populated automatically).
+ // Executes a script. The arguments match mojom::ExecuteCodeParams in
+ // frame.mojom (request_id is populated automatically).
//
// The script will be executed in the frames identified by |frame_ids| (which
// are extension API frame IDs). If |frame_scope| is INCLUDE_SUB_FRAMES,
@@ -130,7 +129,7 @@
}
private:
- // The next value to use for request_id in ExtensionMsg_ExecuteCode_Params.
+ // The next value to use for request_id in mojom::ExecuteCodeParams.
int next_request_id_ = 0;
content::WebContents* web_contents_;
