Google Git
Sign in
chromium / chromium / src / 0a5dd69e0d575aa080c7d74c87b57ed6eb403edc
commit0a5dd69e0d575aa080c7d74c87b57ed6eb403edc[log] [tgz]
authorerikchen <[email protected]>Tue Dec 12 00:53:10 2017
committerCommit Bot <[email protected]>Tue Dec 12 00:53:10 2017
tree64cc36d39b112c76bdaaa7223afe16d1277ee7be
parentc851ab862aaf3d893863cf5a6150d8bf0a22e52a [diff]
Add two new profiling modes for OOP HP.

kAllRenderers will profile all renderers. This allows a user to easily debug
renderer-based memory issues. Adding this mode also allows the removal of some
testing code that had the same effect.

kManual allows the user to manually specify the processes to profile via
chrome://memory-internals. If the user starts profiling a process while in
another mode, the mode will change to kManual for simplicity.

This CL renames the function ShouldProfileProcessType to
ShouldProfileNonRendererProcessType. This CL fixes a bug in
BackgroundProfilingTrigger whereby renderers would never be profiled, since
ShouldProfileProcessType() was incorrectly being used. This logic is no longer
necessary since BackgroundProfilingTrigger queries for all profiled processes by
pid.

Bug: 
Change-Id: Ibeca2346f1629292ca17678081cf0aec68a85ab3
Reviewed-on: https://chromium-review.googlesource.com/818181
Commit-Queue: Erik Chen <[email protected]>
Reviewed-by: Albert J. Wong <[email protected]>
Reviewed-by: Brett Wilson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#523275}
15 files changed
tree: 64cc36d39b112c76bdaaa7223afe16d1277ee7be
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .