Do not check include guards in PRESUBMIT for old IPC *_message_generator.h files
They use the include guards in a very specific, peculiar way
Bug: 814776
Change-Id: I5ff8b8840f88ee993b42d7792be6267d3864f583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728533
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#682943}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 007377f..f6afcd0 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -4077,8 +4077,11 @@
# We only check header files under the control of the Chromium
# project. That is, those outside third_party apart from
# third_party/blink.
+ # We also exclude *_message_generator.h headers as they use
+ # include guards in a special, non-typical way.
file_with_path = input_api.os_path.normpath(f.LocalPath())
return (file_with_path.endswith('.h') and
+ not file_with_path.endswith('_message_generator.h') and
(not file_with_path.startswith('third_party') or
file_with_path.startswith(
input_api.os_path.join('third_party', 'blink'))))
