NetworkService: Make requests with bad referrers fail.
This moves logic for this case from ChromeNetworkDelegate to
NetworkContext's NetworkDelegate, and adds a Mojo parameter to cause
requests with bad referrers to fail (enabled by default).
Also removes the action Net.URLRequest_StartJob_InvalidReferrer rather
than moving it, as it was unowned.
Bug: 852871
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9d6d55157ba28e2b12ca7136b78330100a8673aa
Reviewed-on: https://chromium-review.googlesource.com/1103119
Reviewed-by: Gayane Petrosyan <[email protected]>
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#568807}diff --git a/net/base/layered_network_delegate.cc b/net/base/layered_network_delegate.cc
index 754ce8f..0299fcd 100644
--- a/net/base/layered_network_delegate.cc
+++ b/net/base/layered_network_delegate.cc
@@ -231,18 +231,19 @@
const URLRequest& request,
const GURL& target_url,
const GURL& referrer_url) const {
- OnCancelURLRequestWithPolicyViolatingReferrerHeaderInternal(
- request, target_url, referrer_url);
- return nested_network_delegate_
- ->CancelURLRequestWithPolicyViolatingReferrerHeader(request, target_url,
- referrer_url);
+ return OnCancelURLRequestWithPolicyViolatingReferrerHeaderInternal(
+ request, target_url, referrer_url) ||
+ nested_network_delegate_
+ ->CancelURLRequestWithPolicyViolatingReferrerHeader(
+ request, target_url, referrer_url);
}
-void LayeredNetworkDelegate::
+bool LayeredNetworkDelegate::
OnCancelURLRequestWithPolicyViolatingReferrerHeaderInternal(
const URLRequest& request,
const GURL& target_url,
const GURL& referrer_url) const {
+ return false;
}
bool LayeredNetworkDelegate::OnCanQueueReportingReport(
