| commit | 118dd603e5e36ea9ffc992b4815c0df4639d88b4 | [log] [tgz] |
|---|---|---|
| author | Alexander Dunaev <[email protected]> | Tue Sep 17 09:41:20 2019 |
| committer | Commit Bot <[email protected]> | Tue Sep 17 09:41:20 2019 |
| tree | 2d2fd608be64416257fc72b3d73e1595b97615a1 | |
| parent | b2c850c8b64c2ddb7e2af7d9734febf2086d3d76 [diff] |
[ozone/wayland] Fixed TODO in WaylandWindow::SetBounds. Implementations of PlatformWindow::SetBounds() in WaylandWindow and X11Window are different: the latter calls delegate's OnBoundsChanged always, while the former returns early if the new bounds were the same as the existing ones. There is a comment in the X11 implementation that says that we need to call delegate always because the call might be a result of the device scale factor being changed. We had a TODO in the Wayland implementation saying that we need to investigate this and maybe call the delegate always as well. The simple experiment has shown that when the device scale factor is changed, the window gets new bounds that are not the same as the existing ones, so the delegate is called anyway. As a conclusion, no change is needed, and the TODO can be removed. [email protected] Bug: 958314 Change-Id: I95fcffb43d09702d3dbcc6c2083d2087e7c166f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807823 Reviewed-by: Maksim Sisov <[email protected]> Commit-Queue: Alexander Dunaev <[email protected]> Cr-Commit-Position: refs/heads/master@{#697154}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .