| commit | 12daa3ac9311a8b8a97236e013d20adfbb0b7dc0 | [log] [tgz] |
|---|---|---|
| author | Victor Costan <[email protected]> | Thu Jul 19 01:05:58 2018 |
| committer | Commit Bot <[email protected]> | Thu Jul 19 01:05:58 2018 |
| tree | f1d669549e92963b9776f8162c8f78eef3d8fd04 | |
| parent | 6abfe10de3f70bcdfb5cf54fa70f300a209a5a23 [diff] |
sql: Document sql::StatementID's thread safety properties.
This CL:
1) Extracts StatementID from sql/connection.{h,cc} into its own files
sql/statement_id.{h,cc}.
2) Adds tests specifically targeting sql::StatementID.
3) Replaces passing StatementID by const reference with passing by
value.
4) Removes the StatementID constructor that takes a name, and updates
the call sites to use the source file+line constructor.
Bug: 863724
Change-Id: I5bc6e160fe294189d3e9a2baa8f6be61b21c38d2
Reviewed-on: https://chromium-review.googlesource.com/1137915
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Chris Mumford <[email protected]>
Cr-Commit-Position: refs/heads/master@{#576295}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .