Google Git
Sign in
chromium / chromium / src / 156ff6d76e1b9e7508f005da986eda27729224d2
commit156ff6d76e1b9e7508f005da986eda27729224d2[log] [tgz]
authorKevin Bailey <[email protected]>Thu Oct 26 17:36:00 2017
committerCommit Bot <[email protected]>Thu Oct 26 17:36:00 2017
tree5b92dedff70f62ef4538d4328fc8259fedcd4063
parent903f7f132b1d5cd3126e56a386e024b9ed9435f6 [diff]
Add |IsNotIn| EraseIf-helper and convert to in-place set-intersection

There are a few places where the Omnibox and friends need set-intersection
but they currently construct a new set doing so. With EraseIf and this
IsNotIn helper, it's trivial to do in-place set-intersection. It showed a
20% improvement under micro-benchmarks.

This patch includes an existing Omnibox conversion, plus one under
components/bookmarks.

Bug: 775805
Change-Id: Ic15b5d97c4c04ada4b1e70a3ad159d07909874ec
Reviewed-on: https://chromium-review.googlesource.com/726001
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: danakj <[email protected]>
Commit-Queue: Kevin Bailey <[email protected]>
Cr-Commit-Position: refs/heads/master@{#511864}
4 files changed
tree: 5b92dedff70f62ef4538d4328fc8259fedcd4063
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .