Google Git
Sign in
chromium / chromium / src / 1c21e1e431d9b9c6da1f8d9769b02b09ae5bd16c
commit1c21e1e431d9b9c6da1f8d9769b02b09ae5bd16c[log] [tgz]
authorDarren Shen <[email protected]>Thu May 11 00:03:39 2023
committerChromium LUCI CQ <[email protected]>Thu May 11 00:03:39 2023
tree9915563e1f5dffa556bb8172cc3a7a93e218c21c
parent9dcd81d402f9d583b2dcf94878537005e3a56a95 [diff]
inputs: Introduce ExtendSelectionAndReplace/ReplaceSurroundingText API.

ChromeOS has a common operation of "replace some existing text around
the cursor with some new text". This is used in autocorrection, grammar
check, longpress diacritics etc.

This is currently accomplished by doing ExtendSelectionAndDelete (aka
DeleteSurroundingText), followed by a InsertText (aka CommitText).
There are two problems with this:

1) Because it's not atomic, users may see a brief flash.

2) Some websites do not support ExtendSelectionAndDelete correctly.

Introduce a new ExtendSelectionAndReplace/ReplaceSurroundingText API
that can be used by longpress diacritics on ChromeOS. Blink already
supports this operation for Mac, and we can fallback to the two
separate operations for other clients.

Bug: b/279670207,1443726
Change-Id: I797fcd83d4df972ac8828cae31faa9e6c3dc2543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4485920
Reviewed-by: Robert Kroeger <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1142491}
30 files changed
tree: 9915563e1f5dffa556bb8172cc3a7a93e218c21c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.