Remove base::Value::IsType in //chrome
This change removes base::Value::IsType in the //chrome directory.
It is superfluous and not part of the new API. Existing usages are
replaced by base::Value::is_* if possible (e.g. |val.is_int()| instead
of |val.IsType(base::Value::Type::INTEGER)|). Otherwise, |type()| in
combination with operator== is used (e.g. |val.type() == type| instead
of |val.IsType(type)|).
Bug: 646113
Change-Id: Id285b993173ec190fa0a68487c7be813d4952256
Reviewed-on: https://chromium-review.googlesource.com/732655
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/heads/master@{#510829}diff --git a/chrome/browser/extensions/external_provider_impl.cc b/chrome/browser/extensions/external_provider_impl.cc
index e68c82f..854d319a 100644
--- a/chrome/browser/extensions/external_provider_impl.cc
+++ b/chrome/browser/extensions/external_provider_impl.cc
@@ -240,7 +240,7 @@
bool has_external_version = false;
if (extension->Get(kExternalVersion, &external_version_value)) {
- if (external_version_value->IsType(base::Value::Type::STRING)) {
+ if (external_version_value->is_string()) {
external_version_value->GetAsString(&external_version);
has_external_version = true;
} else {
