Don't allow chromeos unit tests to build in "cros chrome-sdk" shell
The chromeos_* unit test suites are designed to run on Linux, not on
real hardware or in VMs. On the Chromium waterfall they are built
with the linux-chromeos configuration.
Developers using the "cros chrome-sdk" sometimes think they need to
build these targets and run them, either on their host workstation
or on device. The tests aren't expected to work in these environments,
so prevent them from being built.
Bug: 909073, 865693
Test: ninja -C out_eve/Release chromeos_unittests won't compile
Change-Id: Idf8c366f7001ea5bbc744ccba6e627d70f5efebb
Reviewed-on: https://chromium-review.googlesource.com/c/1358509
Commit-Queue: James Cook <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/master@{#614763}diff --git a/testing/test.gni b/testing/test.gni
index d849552b1..4436bab7 100644
--- a/testing/test.gni
+++ b/testing/test.gni
@@ -8,15 +8,15 @@
if (is_android) {
import("//build/config/android/config.gni")
+ import("//build/config/android/extract_unwind_tables.gni")
import("//build/config/android/rules.gni")
import("//build/config/sanitizers/sanitizers.gni")
- import("//build/config/android/extract_unwind_tables.gni")
}
if (is_fuchsia) {
import("//build/config/chromecast_build.gni")
- import("//build/config/fuchsia/rules.gni")
import("//build/config/fuchsia/package.gni")
+ import("//build/config/fuchsia/rules.gni")
}
if (is_chromeos) {
@@ -322,7 +322,7 @@
}
bundle_deps += [ ":$_resources_bundle_data" ]
}
- } else if (is_chromeos && is_chromeos_chrome) {
+ } else if (is_chromeos && is_cros_chrome_sdk) {
# Building for a cros board (ie: not linux-chromeos).
_gen_runner_target = "${target_name}__runner"
