Split WarningService from ExtensionSystem.
This patch removes both the WarningService accessors from
ExtensionSystem and also the ExtensionWarningBadgeService instance
that it created as this can be built automatically for every
BrowserContext simply by declaring so in its new factory.
BUG=
Review URL: https://codereview.chromium.org/698623002
Cr-Commit-Position: refs/heads/master@{#302438}
diff --git a/extensions/browser/warning_service.cc b/extensions/browser/warning_service.cc
index a6fba18..11dc84c9 100644
--- a/extensions/browser/warning_service.cc
+++ b/extensions/browser/warning_service.cc
@@ -6,8 +6,8 @@
#include "content/public/browser/browser_thread.h"
#include "extensions/browser/extension_registry.h"
-#include "extensions/browser/extension_system.h"
#include "extensions/browser/extensions_browser_client.h"
+#include "extensions/browser/warning_service_factory.h"
#include "extensions/common/extension_set.h"
using content::BrowserThread;
@@ -25,6 +25,11 @@
WarningService::~WarningService() {}
+// static
+WarningService* WarningService::Get(content::BrowserContext* browser_context) {
+ return WarningServiceFactory::GetForBrowserContext(browser_context);
+}
+
void WarningService::ClearWarnings(
const std::set<Warning::WarningType>& types) {
DCHECK(CalledOnValidThread());
@@ -95,8 +100,7 @@
return;
}
- WarningService* warning_service =
- ExtensionSystem::Get(browser_context)->warning_service();
+ WarningService* warning_service = WarningService::Get(browser_context);
warning_service->AddWarnings(warnings);
}