Google Git
Sign in
chromium / chromium / src / 26b6c12edd9a09262fc1c08f305890279ed9fb05
commit26b6c12edd9a09262fc1c08f305890279ed9fb05[log] [tgz]
authorCharles Harrison <[email protected]>Sat Nov 04 06:30:46 2017
committerCommit Bot <[email protected]>Sat Nov 04 06:30:46 2017
tree8be8cd19dfad2762df6bbf7a1e6e027a99b79d05
parent1d6cfdd22a5890b0d1bf429d2e9b04a0b39a8507 [diff]
Make main frame navigations consume a user gesture

The tactical purpose of this patch is to constrain tab-unders [1] so
that they are forced to open a popup *before* navigating. This
constraint allows us to do more aggressive interventions in the future,
because pages that do a successful tab-under after this patch will
1. Be forced to navigate after opening a popup (and can be tagged as
   a popup-opening page)
2. Be forced to navigate without a user gesture (since popups consume
   a gesture).

We may be able to intervene on navigations which satisfy (1) and (2) in
the future.

You can see the effects of this patch by loading:
http://cr.kungfoo.net/popups/tab_under/

If you choose "Navigate and then Popup", the popup will be blocked.

Note: This feature is launched behind a disabled-by-default feature
flag. It is currently going through the intent to ship process on blink
dev [2]. It should not be enabled until LG from API owners.

[1]: A tab-under is when a page opens a popup to a link target, while
     also navigating the original page to an ad.

[2]: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kPli8ZCUeok

Bug: 772515
Change-Id: Id45d0b85aa55b0eb5a85bcaecc4ca3f9e551796e
Reviewed-on: https://chromium-review.googlesource.com/676656
Commit-Queue: Charlie Harrison <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#514035}
5 files changed
tree: 8be8cd19dfad2762df6bbf7a1e6e027a99b79d05
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .