Rename net::X509Certificate::Equals to EqualsExcludingChain.
The old name did not make it obvious that the intermediates are not compared.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0b2a3f4e9e2baf5d72fe5ec62e4f7ac91684dbd6
Reviewed-on: https://chromium-review.googlesource.com/1009106
Reviewed-by: Eric Roman <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Matt Mueller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#551219}diff --git a/net/ssl/client_cert_store_unittest-inl.h b/net/ssl/client_cert_store_unittest-inl.h
index 7cc02d3..b054996 100644
--- a/net/ssl/client_cert_store_unittest-inl.h
+++ b/net/ssl/client_cert_store_unittest-inl.h
@@ -91,7 +91,8 @@
&selected_identities);
EXPECT_TRUE(rv);
ASSERT_EQ(1u, selected_identities.size());
- EXPECT_TRUE(selected_identities[0]->certificate()->Equals(cert.get()));
+ EXPECT_TRUE(
+ selected_identities[0]->certificate()->EqualsExcludingChain(cert.get()));
}
// Verify that certificates are correctly filtered against CertRequestInfo with
@@ -127,7 +128,8 @@
&selected_identities);
EXPECT_TRUE(rv);
ASSERT_EQ(1u, selected_identities.size());
- EXPECT_TRUE(selected_identities[0]->certificate()->Equals(cert_1.get()));
+ EXPECT_TRUE(selected_identities[0]->certificate()->EqualsExcludingChain(
+ cert_1.get()));
}
TYPED_TEST_P(ClientCertStoreTest, PrintableStringContainingUTF8) {
@@ -163,7 +165,8 @@
&selected_identities);
EXPECT_TRUE(rv);
ASSERT_EQ(1u, selected_identities.size());
- EXPECT_TRUE(selected_identities[0]->certificate()->Equals(cert.get()));
+ EXPECT_TRUE(
+ selected_identities[0]->certificate()->EqualsExcludingChain(cert.get()));
}
REGISTER_TYPED_TEST_CASE_P(ClientCertStoreTest,
