Record when we suppress internal Extension code JavaScript crashes.
Up until recently the behavior has been to crash on canary and dev channels,
pick those up as regressions as per usual (e.g. we get a nice stack trace),
then not crash in beta or stable.
Recently those crashes have picked up, and while I work on a fix for that,
r327369 disabled all crashes, suppressing all crashes. This patch records all
suppressed crashes, something we perhaps should have been doing for a while.
BUG=471599
[email protected], [email protected]
Review URL: https://codereview.chromium.org/1114733002
Cr-Commit-Position: refs/heads/master@{#327624}
diff --git a/extensions/renderer/module_system.cc b/extensions/renderer/module_system.cc
index b1ea018..05b51b25 100644
--- a/extensions/renderer/module_system.cc
+++ b/extensions/renderer/module_system.cc
@@ -52,10 +52,13 @@
full_message += ") ";
full_message += message;
- if (ExtensionsClient::Get()->ShouldSuppressFatalErrors())
+ ExtensionsClient* client = ExtensionsClient::Get();
+ if (client->ShouldSuppressFatalErrors()) {
console::Error(context->isolate()->GetCallingContext(), full_message);
- else
+ client->RecordDidSuppressFatalError();
+ } else {
console::Fatal(context->isolate()->GetCallingContext(), full_message);
+ }
}
void Warn(v8::Isolate* isolate, const std::string& message) {
