| commit | 3740e073f3276dd189726f9629e8f6acfdc76d4d | [log] [tgz] |
|---|---|---|
| author | Bruce Dawson <[email protected]> | Thu Apr 07 16:17:22 2022 |
| committer | Chromium LUCI CQ <[email protected]> | Thu Apr 07 16:17:22 2022 |
| tree | 2e2ebbae4a35cc9eadcfb2a843e5717ed5cbbe70 | |
| parent | eb2e882c970d13ffc37a1bf836237e073d2ae92a [diff] |
Fix Windows path limits in RunEsLintChecks
When running "git cl presubmit --all" RunEsLintChecks may be called with
~1,100 or more arguments. This leads to a command line that is too long
for Windows to handle. This change invokes eslint multiple times to
avoid hitting the limit.
This change was initially landed as crrev.com/c/3554791 but that change
used the wrong return type and was ultimately done at the wrong level in
the call hierarchy. RunEsLintChecks is the right place to do this change
because it has the list of affected files as a discrete list.
This change can be (and has been) tested with this command (using the
recently added --files option) to make sure it runs to completion:
git cl presubmit --files=*.js --force
For much faster results return early from PanProjectChecks in
depot_tools/presubmit_canned_checks.py.
See crrev.com/c/3554633 for another example of fixing this issue.
This change also adds is_windows to the MockInputAPI - it exists in the
real InputAPI class.
Bug: 1309977, 1312819
Change-Id: Ib2e0bb287b4050b09206b1d2c7155bbc519a4b34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3572912
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Bruce Dawson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#989961}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.