Add PlaybackSpeedButton to chrome://flags
This CL makes sure users can enable/disable the playback speed button on
media controls by adding a dedicated flag.
Change-Id: I0efa481101fc10ee84dfde9fc4a0aafecbec1b40
Bug: 1197485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2905669
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/heads/master@{#884606}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 67e7ad6..617ff71 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -7231,6 +7231,10 @@
FEATURE_VALUE_TYPE(features::kWebUIDownloadShelf)},
#endif // defined(TOOLKIT_VIEWS)
+ {"playback-speed-button", flag_descriptions::kPlaybackSpeedButtonName,
+ flag_descriptions::kPlaybackSpeedButtonDescription, kOsAll,
+ FEATURE_VALUE_TYPE(media::kPlaybackSpeedButton)},
+
// NOTE: Adding a new flag requires adding a corresponding entry to enum
// "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
// Histograms" in tools/metrics/histograms/README.md (run the
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index b5d7e82..32dc1cee 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -4213,6 +4213,11 @@
"expiry_milestone": 92
},
{
+ "name": "playback-speed-button",
+ "owners": [ "steimel", "media-dev" ],
+ "expiry_milestone": 100
+ },
+ {
"name": "pluginvm-fullscreen",
"owners": [ "joelhockey" ],
"expiry_milestone": 96
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index 85ea603..176390c 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -2022,6 +2022,10 @@
"chrome://flags/#quiet-notification-prompts and `Safe Browsing Enhanced "
"Protection` to be enabled.";
+const char kPlaybackSpeedButtonName[] = "Playback Speed Button";
+const char kPlaybackSpeedButtonDescription[] =
+ "Enable the playback speed button on the media controls.";
+
const char kPointerLockOptionsName[] = "Enables pointer lock options";
const char kPointerLockOptionsDescription[] =
"Enables pointer lock unadjustedMovement. When unadjustedMovement is set "
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index 14ece75..1c1865a3 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -1164,6 +1164,9 @@
extern const char kPermissionPredictionsName[];
extern const char kPermissionPredictionsDescription[];
+extern const char kPlaybackSpeedButtonName[];
+extern const char kPlaybackSpeedButtonDescription[];
+
extern const char kPointerLockOptionsName[];
extern const char kPointerLockOptionsDescription[];
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index 04649c6..80b1847 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -48095,6 +48095,7 @@
<int value="939603162" label="BackgroundLoadingForDownloads:disabled"/>
<int value="941036016" label="ContentSuggestionsSettings:disabled"/>
<int value="941883332" label="ProactiveTabFreezeAndDiscard:disabled"/>
+ <int value="941948340" label="PlaybackSpeedButton:enabled"/>
<int value="942807728" label="NewTabstripAnimation:disabled"/>
<int value="943319566" label="enable-intent-picker"/>
<int value="943447234" label="NtpDriveModule:disabled"/>
@@ -48552,6 +48553,7 @@
<int value="1319725131" label="enable-distance-field-text"/>
<int value="1320201920" label="enable-touchpad-three-finger-click"/>
<int value="1320450434" label="ArcUsbStorageUI:disabled"/>
+ <int value="1323808967" label="PlaybackSpeedButton:disabled"/>
<int value="1324623677"
label="SessionRestorePrioritizesBackgroundUseCases:enabled"/>
<int value="1325459977" label="HandwritingGestureEditing:disabled"/>
