Google Git
Sign in
chromium / chromium / src / 4136a0496664207b4a68d32c48cae8990a2bd65d
commit4136a0496664207b4a68d32c48cae8990a2bd65d[log] [tgz]
authorLukasz Anforowicz <[email protected]>Wed Oct 20 00:56:21 2021
committerChromium LUCI CQ <[email protected]>Wed Oct 20 00:56:21 2021
tree022f98b1b149ecadfb33ba1db58b4ccb733964e4
parent6a980f79f45985026cc3e250d87620e026f66ef4 [diff]
Reuse data_decoder::DecodeImage in extensions::ImageSanitizer.

Instead of making a direct mojo call (and manually handling mojo errors)
extensions::ImageSanitizer can call the data_decoder::DecodeImage from
//services/data_decoder/public/cpp.  This helps with:
1) code hygiene (depending only on the public C++ API, ignoring mojo as
   an implementation detail)
2) covering extensions::ImageSanitizer usage with data decoder UMAs
   added in https://crrev.com/c/3116444 (and skipped before this CL,
   when going directly through mojo).

Reusing data_decoder::DecodeImage requires giving
extensions::ImageSanitizer an ability to ask its user for a pointer to a
DataDecoder object.  The CL provides this via a new
ImageSanitizer::Client::GetDataDecoder virtual method.  The CL also
hoists 2 old callbacks (SanitizationDoneCallback and
ImageDecodedCallback) into the Client interface - this helps to simplify
the code a little bit (and a single interface seems cleaner than 3
callbacks).

Bug: 1069271
Change-Id: I7f78120768358dc328fa87e0218b2da251091cf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3139705
Reviewed-by: Istiaque Ahmed <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#933266}
6 files changed
tree: 022f98b1b149ecadfb33ba1db58b4ccb733964e4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.