Google Git
Sign in
chromium / chromium / src / 42f6f8c110af26755d359fc2efa70a9e1264c62c
commit42f6f8c110af26755d359fc2efa70a9e1264c62c[log] [tgz]
authorWeizhong Xia <[email protected]>Tue Oct 11 20:06:55 2022
committerChromium LUCI CQ <[email protected]>Tue Oct 11 20:06:55 2022
tree6b60f668dfb6973cbd45e3bd69a1c41fecb27fec
parentfa2ae41a83a1e3019c34bc13ebfecc4051bc731f [diff]
Reland "Support smoke test file for flag specific suites"

This reverts commit 1062afe8a25592f2166b44a4790848e295fde9cd.

In the previous CL, we have used glob(*) for some paths. Looks that
is causing the problem. Removed the trailing '*'s fixed the issue.

Reason for revert: <Issue fixed>

Original change's description:
> Revert "Support smoke test file for flag specific suites"
>
> This reverts commit 27eccdb2717e88a9084789b0f8931cc78442dfa9.
>
> Reason for revert: <Now highdpi step runs 0 tests, revert first to check>
>
> Original change's description:
> > Support smoke test file for flag specific suites
> >
> > previously we are using test expectations to skip all tests, then
> > using test expectations on individual tests to specify which tests
> > we want to run on a flag specific suite. This will cause the flag
> > specific suite not able to reuse the default test expectations, thus
> > requires additional maintaining effort and sometimes cause confusion.
> >
> > With this change, we allow each flag specific suite to have
> > one optional smoke test file to specify what tests to run.
> >
> > Bug: 1356241
> > Change-Id: Ieb4e67bcf4a13116b745c8c4ad7506f217575f90
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3927975
> > Reviewed-by: Takuto Ikuta <[email protected]>
> > Commit-Queue: Weizhong Xia <[email protected]>
> > Reviewed-by: Preethi Mohan <[email protected]>
> > Reviewed-by: Xianzhu Wang <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1055330}
>
> Bug: 1356241
> Change-Id: Icc6a892f925bad8755317bf0ed6778811d2564ad
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3939132
> Owners-Override: Xianzhu Wang <[email protected]>
> Commit-Queue: Scott Violet <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Weizhong Xia <[email protected]>
> Auto-Submit: Weizhong Xia <[email protected]>
> Reviewed-by: Xianzhu Wang <[email protected]>
> Commit-Queue: Xianzhu Wang <[email protected]>
> Reviewed-by: Preethi Mohan <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1056519}

Bug: 1356241
Change-Id: Ib534bf733186d69b7d3c4f85b66a8fb08ac306b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3941244
Reviewed-by: Preethi Mohan <[email protected]>
Commit-Queue: Weizhong Xia <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Takuto Ikuta <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1057631}
7 files changed
tree: 6b60f668dfb6973cbd45e3bd69a1c41fecb27fec
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.