Reland "Support smoke test file for flag specific suites"
This reverts commit 1062afe8a25592f2166b44a4790848e295fde9cd.
In the previous CL, we have used glob(*) for some paths. Looks that
is causing the problem. Removed the trailing '*'s fixed the issue.
Reason for revert: <Issue fixed>
Original change's description:
> Revert "Support smoke test file for flag specific suites"
>
> This reverts commit 27eccdb2717e88a9084789b0f8931cc78442dfa9.
>
> Reason for revert: <Now highdpi step runs 0 tests, revert first to check>
>
> Original change's description:
> > Support smoke test file for flag specific suites
> >
> > previously we are using test expectations to skip all tests, then
> > using test expectations on individual tests to specify which tests
> > we want to run on a flag specific suite. This will cause the flag
> > specific suite not able to reuse the default test expectations, thus
> > requires additional maintaining effort and sometimes cause confusion.
> >
> > With this change, we allow each flag specific suite to have
> > one optional smoke test file to specify what tests to run.
> >
> > Bug: 1356241
> > Change-Id: Ieb4e67bcf4a13116b745c8c4ad7506f217575f90
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3927975
> > Reviewed-by: Takuto Ikuta <[email protected]>
> > Commit-Queue: Weizhong Xia <[email protected]>
> > Reviewed-by: Preethi Mohan <[email protected]>
> > Reviewed-by: Xianzhu Wang <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1055330}
>
> Bug: 1356241
> Change-Id: Icc6a892f925bad8755317bf0ed6778811d2564ad
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3939132
> Owners-Override: Xianzhu Wang <[email protected]>
> Commit-Queue: Scott Violet <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Weizhong Xia <[email protected]>
> Auto-Submit: Weizhong Xia <[email protected]>
> Reviewed-by: Xianzhu Wang <[email protected]>
> Commit-Queue: Xianzhu Wang <[email protected]>
> Reviewed-by: Preethi Mohan <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1056519}
Bug: 1356241
Change-Id: Ib534bf733186d69b7d3c4f85b66a8fb08ac306b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3941244
Reviewed-by: Preethi Mohan <[email protected]>
Commit-Queue: Weizhong Xia <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Takuto Ikuta <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1057631}
diff --git a/BUILD.gn b/BUILD.gn
index ab99afc..a6b18de 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -1439,6 +1439,7 @@
"//third_party/blink/web_tests/FlagSpecificConfig",
"//third_party/blink/web_tests/FlagExpectations/",
"//third_party/blink/web_tests/flag-specific/",
+ "//third_party/blink/web_tests/SmokeTests/",
]
}
}
@@ -1504,6 +1505,7 @@
"//third_party/blink/web_tests/FlagSpecificConfig",
"//third_party/blink/web_tests/FlagExpectations/",
"//third_party/blink/web_tests/flag-specific/",
+ "//third_party/blink/web_tests/SmokeTests/",
]
}
}
