Google Git
Sign in
chromium / chromium / src / 45d9ae2da2bc28c1dcae57cc9be6c8f3c98ab6fe
commit45d9ae2da2bc28c1dcae57cc9be6c8f3c98ab6fe[log] [tgz]
authorTrent Apted <[email protected]>Thu Nov 09 23:12:32 2017
committerCommit Bot <[email protected]>Thu Nov 09 23:12:32 2017
tree6c42ff44f6d324bc526e60084c2b097dc28cd58a
parentf02091998c3ca16eb2f98d460b264c507ecabb7e [diff]
Mac: Don't crash trying to process a menu command during shutdown.

When something calls chrome::AttemptExit(), lots of stuff happens.
It involves RunLoops, and there's no guarantee the OS won't put
something into the event queue while Chrome is cleaning up the last
browser window.

If that "something" is "Open a New Window" BrowserProcessImpl::Pin()
gets unhappy and will CHECK() because it thought the last browser
window was already closed.

To fix, don't allow AppController to process commands after it has
cleared its keep alive. Since, this may trigger BrowserProcessImpl::UnPin()
and enter this state where it's prohibited to open new windows.

Bug: 779829
Change-Id: I4ac2533d27ed724bc24cf546be69560506705cb8
Reviewed-on: https://chromium-review.googlesource.com/752981
Commit-Queue: Trent Apted <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#515338}
2 files changed
tree: 6c42ff44f6d324bc526e60084c2b097dc28cd58a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .