Google Git
Sign in
chromium / chromium / src / 4bca290ac4b9a4d763068a31917a9e2dbd4c600f
commit4bca290ac4b9a4d763068a31917a9e2dbd4c600f[log] [tgz]
authorEmily Stark <[email protected]>Mon Jun 29 21:02:30 2020
committerCommit Bot <[email protected]>Mon Jun 29 21:02:30 2020
treeec3c08adfc5fdcf684d07bca7ea8c7722796e75b
parent73410df6f283c921447f61e9d86c7fd04deb9bbc [diff]
Omnibox UI: animate URL elisions from both ends of URL

This CL adds a field trial option to elide not just the path, but also
subdomains beyond the registrable domain. To support this option, the
animation has to get fancier: we can now longer fade the color of the
path, but must instead animate the display rect and offset. (The mocks
also have a fade that happens while the display rect is changing, but
I haven't implemented that yet.)

I've replaced PathFadeAnimation with ElideAnimation that elides or
unelides to a particular range of the string. Because the animation
sets and can query state on the RenderText (the display rect and
display offset), we can collapse the hover fade-in and fade-out
animations into one animation.

I've also cleaned up a couple other things along the way, mostly
removing the extra has_started_ state on the animation and replacing
it with GetCurrentValue().

Bug: 1090393
Change-Id: Iccd3ba52b74152bf207c440a549a8314da3da704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261893
Commit-Queue: Emily Stark <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Commit-Position: refs/heads/master@{#783666}
12 files changed
tree: ec3c08adfc5fdcf684d07bca7ea8c7722796e75b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.