Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.
Presently when we selects bookmark icon then it checks weather Ctrl+D has been set as overridden command for any extension if yes, then it executes extension popup for that extension.
Changes done so that when bookmarking a page is done via bookmark icon by mouse click then bookmark overridden commands should not be considered as overriding happened for keyboard shortcuts.
As user have overridden shortcut key for bookmark to launch extension pop up, not the bookmarking via selection of bookmark icon by mouse event.
[email protected]
BUG=426791
Review URL: https://codereview.chromium.org/765043002
Cr-Commit-Position: refs/heads/master@{#308312}
diff --git a/chrome/browser/browser_commands_unittest.cc b/chrome/browser/browser_commands_unittest.cc
index eb110ad..b92d173 100644
--- a/chrome/browser/browser_commands_unittest.cc
+++ b/chrome/browser/browser_commands_unittest.cc
@@ -149,7 +149,7 @@
browser()->OpenURL(OpenURLParams(
url1, Referrer(), CURRENT_TAB, ui::PAGE_TRANSITION_TYPED, false));
- chrome::BookmarkCurrentPage(browser());
+ chrome::BookmarkCurrentPageAllowingExtensionOverrides(browser());
// It should now be bookmarked in the bookmark model.
EXPECT_EQ(profile(), browser()->profile());
