commit 5728d85d64e4e6ff62c520cb2ddcf17cf17e7aaa
author torne <torne@chromium.org> Fri Dec 04 14:10:11 2015
committer Commit bot <commit-bot@chromium.org> Fri Dec 04 14:11:14 2015
tree b96092cd890aac99fa13aa7e11d22fef3e18fcf0
parent 91f34c5d7de95f013d3023ab0a2664e3358710e9

Pass method parameters as JavaParamRef in android_webview.

Pass all object parameters to JNI methods in JavaParamRef<> wrappers.
This matches previous changes made to do this for JNI non-method
functions.

BUG=506850

Review URL: https://codereview.chromium.org/1492703004

Cr-Commit-Position: refs/heads/master@{#363198}

android_webview/native/aw_settings.h

diff --git a/android_webview/native/aw_settings.h b/android_webview/native/aw_settings.h
index 56b09ad..79d4f758 100644
--- a/android_webview/native/aw_settings.h
+++ b/android_webview/native/aw_settings.h
@@ -29,16 +29,33 @@
 
   // Called from Java. Methods with "Locked" suffix require that the settings
   // access lock is held during their execution.
-  void Destroy(JNIEnv* env, jobject obj);
-  void PopulateWebPreferencesLocked(JNIEnv* env, jobject obj, jlong web_prefs);
-  void ResetScrollAndScaleState(JNIEnv* env, jobject obj);
-  void UpdateEverythingLocked(JNIEnv* env, jobject obj);
-  void UpdateInitialPageScaleLocked(JNIEnv* env, jobject obj);
-  void UpdateUserAgentLocked(JNIEnv* env, jobject obj);
-  void UpdateWebkitPreferencesLocked(JNIEnv* env, jobject obj);
-  void UpdateFormDataPreferencesLocked(JNIEnv* env, jobject obj);
-  void UpdateRendererPreferencesLocked(JNIEnv* env, jobject obj);
-  void UpdateOffscreenPreRasterLocked(JNIEnv* env, jobject obj);
+  void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
+  void PopulateWebPreferencesLocked(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& obj,
+      jlong web_prefs);
+  void ResetScrollAndScaleState(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& obj);
+  void UpdateEverythingLocked(JNIEnv* env,
+                              const base::android::JavaParamRef<jobject>& obj);
+  void UpdateInitialPageScaleLocked(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& obj);
+  void UpdateUserAgentLocked(JNIEnv* env,
+                             const base::android::JavaParamRef<jobject>& obj);
+  void UpdateWebkitPreferencesLocked(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& obj);
+  void UpdateFormDataPreferencesLocked(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& obj);
+  void UpdateRendererPreferencesLocked(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& obj);
+  void UpdateOffscreenPreRasterLocked(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& obj);
 
   void PopulateWebPreferences(content::WebPreferences* web_prefs);