| commit | 627dc8c76a66a8c6251c6d0423e8782b101bb050 | [log] [tgz] |
|---|---|---|
| author | johnme <[email protected]> | Fri Aug 19 21:49:39 2016 |
| committer | Commit bot <[email protected]> | Fri Aug 19 21:52:33 2016 |
| tree | b549a1e3ebc84f10498d10ae4a3d9eb4e8e311db | |
| parent | 45ec6fecc32bff5541c237c98228122f3252902e [diff] |
Add support for GCM subtypes to desktop Instance ID implementation Adds support for subtypes to the desktop Instance ID implementation. A follow-on patch will switch Web Push to use subtypes on desktop. Chrome Apps/Extensions will be unchanged. The main benefit will be consistency between desktop and Android - both will be able to use subtypes for the app_id, rather than sending app_id to GCM as the category field (package name) on desktop only. This will avoid spamming GCM's category column with many unique values (since each app_id that Push generates contains a random GUID). Part of a series of patches: 1. https://codereview.chromium.org/1832833002 adds InstanceIDWithSubtype 2. https://codereview.chromium.org/1830983002 adds JNI bindings 3. https://codereview.chromium.org/1829023002 adds fake and test 4. https://codereview.chromium.org/1899753002 fixes strict mode violations 5. https://codereview.chromium.org/1854093002 enables InstanceID by default 6. https://codereview.chromium.org/1953273002 extends the GCMKeyStore 7. https://codereview.chromium.org/1923953002 integrates IIDs with crypto 8. this patch 9. https://codereview.chromium.org/1851423003 switches Push to InstanceIDs Also depends on - https://codereview.chromium.org/2148163003 fix test asserts - https://codereview.chromium.org/2217803003 EXPECT_DCHECK BUG=533498,589461 Review-Url: https://codereview.chromium.org/2111973002 Cr-Commit-Position: refs/heads/master@{#413259}