| commit | 645d4234a6753a73f0b0f2a1e591cb2460d5a00c | [log] [tgz] |
|---|---|---|
| author | Dominic Battre <[email protected]> | Fri Dec 04 16:14:10 2020 |
| committer | Chromium LUCI CQ <[email protected]> | Fri Dec 04 16:14:10 2020 |
| tree | e35129440f43170f54d658e45f8a678ac84ed01e | |
| parent | 2d3a3d1cbc95eeeea385120aea911b8ff4230d36 [diff] |
Check deprecation of preferences It's a common mistake that developers just remove Register...Pref() calls for preferences they don't need anymore. If they do this, the preference stays in the prefs files on disk for ever. A proper approach is to first ClearPref() the preference for some releases and then to remove the code. This CL introduces a presubmit warning if we detect that a Register...Pref() call is removed from a non-unittest. Bug: 1153014 Change-Id: If8f19933de039553ef47e0ddce12eb194df45ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560205 Commit-Queue: Dominic Battré <[email protected]> Reviewed-by: Jochen Eisinger <[email protected]> Reviewed-by: Gabriel Charette <[email protected]> Reviewed-by: Dominic Battré <[email protected]> Cr-Commit-Position: refs/heads/master@{#833730}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.