[RDSG] Silently report crashes for debugging
To investigate <10" devices in RDS default-on cohort, silently report
crashes for debugging when:
- Display size falls below threshold
- Display size falls into overflow bucket
Flag guarded with REQUEST_DESKTOP_SITE_DEFAULTS_LOGGING.
Bug: 1418537
Change-Id: Ib76df7c1ba146e32b6b7bac7580c157f20ccf609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4285402
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Sirisha Kavuluru <[email protected]>
Commit-Queue: Shu Yang <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1110678}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index b7b86e28..d997145 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -8861,6 +8861,14 @@
#endif // BUILDFLAG(IS_ANDROID)
#if BUILDFLAG(IS_ANDROID)
+ {"request-desktop-site-defaults-logging",
+ flag_descriptions::kRequestDesktopSiteDefaultsLoggingName,
+ flag_descriptions::kRequestDesktopSiteDefaultsLoggingDescription,
+ kOsAndroid,
+ FEATURE_VALUE_TYPE(chrome::android::kRequestDesktopSiteDefaultsLogging)},
+#endif // BUILDFLAG(IS_ANDROID)
+
+#if BUILDFLAG(IS_ANDROID)
{"request-desktop-site-exceptions-downgrade",
flag_descriptions::kRequestDesktopSiteExceptionsDowngradeName,
flag_descriptions::kRequestDesktopSiteExceptionsDowngradeDescription,
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index 2b2cb84..83e656e 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -6127,6 +6127,11 @@
"expiry_milestone": 114
},
{
+ "name": "request-desktop-site-defaults-logging",
+ "owners": [ "[email protected]", "[email protected]" ],
+ "expiry_milestone": 116
+ },
+ {
"name": "request-desktop-site-exceptions",
"owners": [ "[email protected]", "twellington", "[email protected]" ],
"expiry_milestone": 114
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index b7aaeb3..5ed0941 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -3922,6 +3922,12 @@
"Disable the request desktop site global setting if it was enabled by "
"default based on device conditions.";
+const char kRequestDesktopSiteDefaultsLoggingName[] =
+ "Silently report crashes for debugging request desktop site on Android.";
+const char kRequestDesktopSiteDefaultsLoggingDescription[] =
+ "Silently report crashes with display spec when ineligible device shows "
+ "up in cohort or device screen size exceeds threshold.";
+
const char kRequestDesktopSiteExceptionsDowngradeName[] =
"Downgrade request desktop site exceptions on Android.";
const char kRequestDesktopSiteExceptionsDowngradeDescription[] =
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index f02ea7e..9479002 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -2248,6 +2248,9 @@
extern const char kRequestDesktopSiteDefaultsDowngradeName[];
extern const char kRequestDesktopSiteDefaultsDowngradeDescription[];
+extern const char kRequestDesktopSiteDefaultsLoggingName[];
+extern const char kRequestDesktopSiteDefaultsLoggingDescription[];
+
extern const char kRequestDesktopSiteExceptionsName[];
extern const char kRequestDesktopSiteExceptionsDescription[];
diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browser/flags/android/chrome_feature_list.cc
index 8a9a5bb..aa6a263 100644
--- a/chrome/browser/flags/android/chrome_feature_list.cc
+++ b/chrome/browser/flags/android/chrome_feature_list.cc
@@ -274,6 +274,7 @@
&kRequestDesktopSiteOptInControlSynthetic,
&kRequestDesktopSiteOptInSynthetic,
&kRequestDesktopSiteDefaultsDowngrade,
+ &kRequestDesktopSiteDefaultsLogging,
&kRequestDesktopSitePerSiteIph,
&kSafeModeForCachedFlags,
&kShowScrollableMVTOnNTPAndroid,
@@ -897,6 +898,10 @@
"RequestDesktopSiteDefaultsDowngrade",
base::FEATURE_DISABLED_BY_DEFAULT);
+BASE_FEATURE(kRequestDesktopSiteDefaultsLogging,
+ "RequestDesktopSiteDefaultsLogging",
+ base::FEATURE_DISABLED_BY_DEFAULT);
+
BASE_FEATURE(kRequestDesktopSitePerSiteIph,
"RequestDesktopSitePerSiteIph",
base::FEATURE_DISABLED_BY_DEFAULT);
diff --git a/chrome/browser/flags/android/chrome_feature_list.h b/chrome/browser/flags/android/chrome_feature_list.h
index 92e01a54..a0e1f87 100644
--- a/chrome/browser/flags/android/chrome_feature_list.h
+++ b/chrome/browser/flags/android/chrome_feature_list.h
@@ -138,6 +138,7 @@
BASE_DECLARE_FEATURE(kRequestDesktopSiteOptInControlSynthetic);
BASE_DECLARE_FEATURE(kRequestDesktopSiteOptInSynthetic);
BASE_DECLARE_FEATURE(kRequestDesktopSiteDefaultsDowngrade);
+BASE_DECLARE_FEATURE(kRequestDesktopSiteDefaultsLogging);
BASE_DECLARE_FEATURE(kRequestDesktopSitePerSiteIph);
BASE_DECLARE_FEATURE(kSharingHubLinkToggle);
BASE_DECLARE_FEATURE(kShowScrollableMVTOnNTPAndroid);
diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
index be2470d..d950d322 100644
--- a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
+++ b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
@@ -452,6 +452,8 @@
"RequestDesktopSiteDefaultsControlSynthetic";
public static final String REQUEST_DESKTOP_SITE_DEFAULTS_DOWNGRADE =
"RequestDesktopSiteDefaultsDowngrade";
+ public static final String REQUEST_DESKTOP_SITE_DEFAULTS_LOGGING =
+ "RequestDesktopSiteDefaultsLogging";
public static final String REQUEST_DESKTOP_SITE_DEFAULTS_SYNTHETIC =
"RequestDesktopSiteDefaultsSynthetic";
public static final String REQUEST_DESKTOP_SITE_OPT_IN_CONTROL_SYNTHETIC =
diff --git a/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java b/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
index 038e363..7e18844f 100644
--- a/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
+++ b/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
@@ -259,6 +259,12 @@
*/
public static final String DESKTOP_SITE_EXCEPTIONS_DOWNGRADE_TAB_SETTING_SET =
"Chrome.RequestDesktopSiteExceptionsDowngrade.TabSettingSet";
+ /**
+ * Indicates display spec when the device is added to the default-on cohort for the desktop site
+ * global setting experiment.
+ */
+ public static final String DESKTOP_SITE_GLOBAL_SETTING_DEFAULT_ON_COHORT_DISPLAY_SPEC =
+ "Chrome.RequestDesktopSiteGlobalSetting.DefaultOnCohortDisplaySpec";
public static final String DOWNLOAD_AUTO_RESUMPTION_ATTEMPT_LEFT = "ResumptionAttemptLeft";
public static final String DOWNLOAD_FOREGROUND_SERVICE_OBSERVERS = "ForegroundServiceObservers";
@@ -1034,6 +1040,7 @@
DEFAULT_ENABLE_DESKTOP_SITE_GLOBAL_SETTING_COHORT,
DESKTOP_SITE_EXCEPTIONS_DOWNGRADE_GLOBAL_SETTING_ENABLED,
DESKTOP_SITE_EXCEPTIONS_DOWNGRADE_TAB_SETTING_SET,
+ DESKTOP_SITE_GLOBAL_SETTING_DEFAULT_ON_COHORT_DISPLAY_SPEC,
DESKTOP_SITE_GLOBAL_SETTING_OPT_IN_MESSAGE_COHORT,
DOWNLOAD_INTERSTITIAL_DOWNLOAD_PENDING_REMOVAL,
EXPLORE_OFFLINE_CONTENT_AVAILABILITY_STATUS,
