Projector: Add local playback feature flag to chrome://flags
This CL adds ProjectorLocalPlayback and ProjectorAppDebug flags to
chrome://flags to facilitate our team's bug bash and development ease.
Our PM has indicated that confidentiality is not a concern for this
new feature.
Bug: b:237089852
Change-Id: Idd54b420338e5701bd4a2d17a69986bed1de1d76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828201
Auto-Submit: Toby Huang <[email protected]>
Commit-Queue: Toby Huang <[email protected]>
Reviewed-by: Yilkal Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1034560}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 32f6e36..9943979c 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -8725,6 +8725,15 @@
flag_descriptions::kProjectorExcludeTranscriptName,
flag_descriptions::kProjectorExcludeTranscriptDescription, kOsCrOS,
FEATURE_VALUE_TYPE(ash::features::kProjectorExcludeTranscript)},
+
+ {"enable-projector-local-playback",
+ flag_descriptions::kProjectorLocalPlaybackName,
+ flag_descriptions::kProjectorLocalPlaybackDescription, kOsCrOS,
+ FEATURE_VALUE_TYPE(ash::features::kProjectorLocalPlayback)},
+
+ {"enable-projector-app-debug", flag_descriptions::kProjectorAppDebugName,
+ flag_descriptions::kProjectorAppDebugDescription, kOsCrOS,
+ FEATURE_VALUE_TYPE(ash::features::kProjectorAppDebug)},
#endif // BUILDFLAG(IS_CHROMEOS_ASH)
{"web-sql-access", flag_descriptions::kWebSQLAccessName,
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index cf35861..e18075af 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -2720,11 +2720,21 @@
"expiry_milestone": 105
},
{
+ "name": "enable-projector-app-debug",
+ "owners": [ "tobyhuang", "[email protected]" ],
+ "expiry_milestone": 108
+ },
+ {
"name": "enable-projector-exclude-transcript",
"owners": [ "llin", "[email protected]" ],
"expiry_milestone": 105
},
{
+ "name": "enable-projector-local-playback",
+ "owners": [ "tobyhuang", "[email protected]" ],
+ "expiry_milestone": 108
+ },
+ {
"name": "enable-quic",
"owners": [ "//net/quic/OWNERS" ],
// This flag is used by network administrators to debug
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index 3c0c70c2..da09a00 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -5631,12 +5631,21 @@
const char kProjectorAnnotatorName[] = "Enable Projector annotator";
const char kProjectorAnnotatorDescription[] =
- "Turns on annotator tools when recording a screen capture using projector";
+ "Turns on annotator tools when recording a screen capture using Projector";
const char kProjectorExcludeTranscriptName[] =
"Enable Projector exclude transcript feature";
const char kProjectorExcludeTranscriptDescription[] =
- "Support excluding segment of Projector recording by excluding transcript";
+ "Supports excluding segment of Projector recording by excluding transcript";
+
+const char kProjectorLocalPlaybackName[] = "Enable Projector local playback";
+const char kProjectorLocalPlaybackDescription[] =
+ "Supports streaming screencast videos from DriveFS instead of Drive before "
+ "they have finished transcoding";
+
+const char kProjectorAppDebugName[] = "Enable Projector app debug";
+const char kProjectorAppDebugDescription[] =
+ "Adds more informative error messages to the Projector app for debugging";
const char kQsRevampName[] = "Quick Settings Revamp";
const char kQsRevampDescription[] =
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index cd0e3c0..8d1897d 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -3226,6 +3226,12 @@
extern const char kProjectorExcludeTranscriptName[];
extern const char kProjectorExcludeTranscriptDescription[];
+extern const char kProjectorLocalPlaybackName[];
+extern const char kProjectorLocalPlaybackDescription[];
+
+extern const char kProjectorAppDebugName[];
+extern const char kProjectorAppDebugDescription[];
+
extern const char kQsRevampName[];
extern const char kQsRevampDescription[];
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index c19753a37..1971e98 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -57381,6 +57381,7 @@
<int value="-1099496822" label="CaptureModeSelfieCamera:enabled"/>
<int value="-1099142083" label="V8Ignition:disabled"/>
<int value="-1099135056" label="AsyncDns:enabled"/>
+ <int value="-1098963611" label="ProjectorLocalPlayback:disabled"/>
<int value="-1097977406"
label="SupervisedUserCommittedInterstitials:enabled"/>
<int value="-1096595907" label="disable-new-virtual-keyboard-behavior"/>
@@ -58653,6 +58654,7 @@
<int value="-297716805"
label="CrossOriginMediaPlaybackRequiresUserGesture:disabled"/>
<int value="-296762162" label="ExoOrdinalMotion:enabled"/>
+ <int value="-296493265" label="ProjectorAppDebug:enabled"/>
<int value="-296179618" label="CookiesWithoutSameSiteMustBeSecure:enabled"/>
<int value="-295237704" label="EnableRemovingAllThirdPartyCookies:enabled"/>
<int value="-291936879" label="UsernameFirstFlowFilling:disabled"/>
@@ -58858,6 +58860,7 @@
<int value="-152632720" label="RuntimeHostPermissions:enabled"/>
<int value="-152596707" label="NearbySharingSelfShare:enabled"/>
<int value="-152439608" label="download-later-debug-on-wifi"/>
+ <int value="-150820109" label="ProjectorAppDebug:disabled"/>
<int value="-150077791" label="FontAccessChooser:disabled"/>
<int value="-148356419" label="PdfViewerPresentationMode:disabled"/>
<int value="-147560822" label="ArcInputOverlay:enabled"/>
@@ -61742,6 +61745,7 @@
<int value="1685280468" label="AppServiceShelf:enabled"/>
<int value="1687544136" label="AndroidManagedByMenuItem:enabled"/>
<int value="1688075820" label="OmniboxExperimentalKeywordMode:disabled"/>
+ <int value="1689001971" label="ProjectorLocalPlayback:enabled"/>
<int value="1689123607" label="enable-app-link"/>
<int value="1689183477" label="enable-merge-key-char-events"/>
<int value="1690248203" label="HelpAppV2:enabled"/>
