| commit | 6da0aba4c6866104171ae754010cc19f33c2fcfb | [log] [tgz] |
|---|---|---|
| author | Peter Boström <[email protected]> | Mon Jan 30 20:13:31 2023 |
| committer | Chromium LUCI CQ <[email protected]> | Mon Jan 30 20:13:31 2023 |
| tree | bfbd14305c5d0818905b06bc90e0edb14d8e6979 | |
| parent | b9d1f59b3b7a375635e1feefeb195c0a5d1c6760 [diff] [blame] |
Revert "Remove NOTREACHED() dumping for official builds" This reverts commit a1b3c712053d9323c935d201dbf7881c71936f83. Reason for revert: Perf regression, will try a smaller revert. Original change's description: > Remove NOTREACHED() dumping for official builds > > This is to be merged to M111. A follow-up change will enable > `enable_log_error_not_reached` that will allow us to dump again (with > more data), and we can then decide if that should follow M112 all the > way to stable before we make this fatal, or if we need to strip the > useful debug info from reporting before we hit stable. > > Bug: 851128 > Change-Id: Iec9bfe61ec8988d6e6017f7a64ec0401d0f541d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200079 > Auto-Submit: Peter Boström <[email protected]> > Commit-Queue: danakj <[email protected]> > Reviewed-by: danakj <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1098455} Bug: 851128, 1411319 Change-Id: I17ba4e8d3d30bd8098a228cfb030223d8cadbedb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4205307 Commit-Queue: danakj <[email protected]> Reviewed-by: danakj <[email protected]> Auto-Submit: Peter Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#1098802}
diff --git a/base/check.h b/base/check.h index 52bc2d4..99db3eb 100644 --- a/base/check.h +++ b/base/check.h
@@ -101,6 +101,10 @@ public: static NotReachedError NotReached(const char* file, int line); + // Used to trigger a NOTREACHED() without providing file or line while also + // discarding log-stream arguments. See base/notreached.h. + NOMERGE NOINLINE NOT_TAIL_CALLED static void TriggerNotReached(); + // TODO(crbug.com/851128): Mark [[noreturn]] once this is CHECK-fatal on all // builds. NOMERGE NOINLINE NOT_TAIL_CALLED ~NotReachedError();