| commit | 6fe52aa20e9426e16aa7204b0c5426895eb1c629 | [log] [tgz] |
|---|---|---|
| author | Chris Watkins <[email protected]> | Tue Nov 28 03:24:05 2017 |
| committer | Commit Bot <[email protected]> | Tue Nov 28 03:24:05 2017 |
| tree | e2e1f359b8795112d19071351a107f45c1debd6d | |
| parent | bcfb895bd39c421db37531d48accf340b4c0440f [diff] [blame] |
Run clang-tidy modernize-use-equals-{delete,default} on //remoting
See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8
This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
git diff --name-only | \
xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'
BUG=778959,778957
Change-Id: I3805211c70d2c2340afa4d6d956339d1b25751fc
Reviewed-on: https://chromium-review.googlesource.com/789728
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Chris Watkins <[email protected]>
Cr-Commit-Position: refs/heads/master@{#519543}diff --git a/remoting/protocol/video_frame_pump.cc b/remoting/protocol/video_frame_pump.cc index da22a2fe..312fd70 100644 --- a/remoting/protocol/video_frame_pump.cc +++ b/remoting/protocol/video_frame_pump.cc
@@ -30,15 +30,15 @@ // must be smaller than the minimum RTO used in PseudoTCP, which is 250ms. static const int kKeepAlivePacketIntervalMs = 200; -VideoFramePump::FrameTimestamps::FrameTimestamps() {} -VideoFramePump::FrameTimestamps::~FrameTimestamps() {} +VideoFramePump::FrameTimestamps::FrameTimestamps() = default; +VideoFramePump::FrameTimestamps::~FrameTimestamps() = default; VideoFramePump::PacketWithTimestamps::PacketWithTimestamps( std::unique_ptr<VideoPacket> packet, std::unique_ptr<FrameTimestamps> timestamps) : packet(std::move(packet)), timestamps(std::move(timestamps)) {} -VideoFramePump::PacketWithTimestamps::~PacketWithTimestamps() {} +VideoFramePump::PacketWithTimestamps::~PacketWithTimestamps() = default; VideoFramePump::VideoFramePump( scoped_refptr<base::SingleThreadTaskRunner> encode_task_runner,