Google Git
Sign in
chromium / chromium / src / 70c9502ac61e3ae3d3499eefa208d40706fcfeb1
commit70c9502ac61e3ae3d3499eefa208d40706fcfeb1[log] [tgz]
authorAlexei Svitkine <[email protected]>Wed Aug 21 18:13:24 2019
committerCommit Bot <[email protected]>Wed Aug 21 18:13:24 2019
treee3b7295b89b1b517dc33acad345f241c1230b72e
parentfc8c281457d48053b98b302bf11fce10a772e820 [diff]
Re-land "Add full system profiles in .pma file as part of metrics init."

Originally landed as:
https://chromium-review.googlesource.com/c/chromium/src/+/1746909

This reland has a fix for the bug where core system profile
information was being cleared by RecordEnvironment(). In the reland
I'm removing the IsTestingID() logic was interfering with a new test
I'm adding and that turned out to be unnecessary for any other test.

Prior to this change, only an incomplete system profile, notably
missing field trials and uma_default_state fields, was stored
at this point. So unclean shut downs after this point in time,
but before the initial metrics log was saved would not include
that info. This change fixes that by running the code that
populates all the system profile fields.

Since we're now calling ProvideSystemProfileMetrics() twice, the
logic in FieldTrialsProvider was no longer correct in tracking
the log creation time. Instead, this CL updates the API to have
that be passed in.

Additionally, Chrome OS an Screen Info providers needed updates since
their dependencies are not yet available this early, so they are not
able to provide all the information this early.

Finally, webview unit tests needed updating to init mojo as they are
now exercising the provider code which has a Mojo dependency.

Bug: 992538
Change-Id: Id52b63bb4d98b9f6133b3ba202b9253eaa88c195
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746909
Commit-Queue: Alexei Svitkine <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Brian White <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#687000}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758436
Cr-Commit-Position: refs/heads/master@{#689079}
22 files changed
tree: e3b7295b89b1b517dc33acad345f241c1230b72e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .