Switch a bunch of //net to std::string::data and std::vector::data.
I don't have any immediate evidence that these are called on empty
strings or vectors, but this was an easy enough regex to write so just
fix them.
Bug: 923166
Change-Id: Iea616099c2ce755e2783e4929911e5844049bba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894623
Reviewed-by: Ryan Sleevi <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Ryan Sleevi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#711629}
diff --git a/net/websockets/websocket_frame_test.cc b/net/websockets/websocket_frame_test.cc
index 9184155..d2cf0fe 100644
--- a/net/websockets/websocket_frame_test.cc
+++ b/net/websockets/websocket_frame_test.cc
@@ -44,7 +44,7 @@
kTests[i].frame_header + kTests[i].frame_header_length);
std::vector<char> output(expected_output.size());
EXPECT_EQ(static_cast<int>(expected_output.size()),
- WriteWebSocketFrameHeader(header, nullptr, &output.front(),
+ WriteWebSocketFrameHeader(header, nullptr, output.data(),
output.size()));
EXPECT_EQ(expected_output, output);
}
@@ -89,8 +89,8 @@
kTests[i].frame_header + kTests[i].frame_header_length);
std::vector<char> output(expected_output.size());
EXPECT_EQ(static_cast<int>(expected_output.size()),
- WriteWebSocketFrameHeader(
- header, &masking_key, &output.front(), output.size()));
+ WriteWebSocketFrameHeader(header, &masking_key, output.data(),
+ output.size()));
EXPECT_EQ(expected_output, output);
}
}
@@ -132,7 +132,7 @@
kTests[i].frame_header + kTests[i].frame_header_length);
std::vector<char> output(expected_output.size());
EXPECT_EQ(static_cast<int>(expected_output.size()),
- WriteWebSocketFrameHeader(header, nullptr, &output.front(),
+ WriteWebSocketFrameHeader(header, nullptr, output.data(),
output.size()));
EXPECT_EQ(expected_output, output);
}
@@ -171,7 +171,7 @@
kTests[i].frame_header + kTests[i].frame_header_length);
std::vector<char> output(expected_output.size());
EXPECT_EQ(static_cast<int>(expected_output.size()),
- WriteWebSocketFrameHeader(header, nullptr, &output.front(),
+ WriteWebSocketFrameHeader(header, nullptr, output.data(),
output.size()));
EXPECT_EQ(expected_output, output);
}
@@ -246,9 +246,9 @@
kTests[i].input + kTests[i].data_length);
std::vector<char> expected_output(kTests[i].output,
kTests[i].output + kTests[i].data_length);
- MaskWebSocketFramePayload(
- masking_key, kTests[i].frame_offset,
- frame_data.empty() ? nullptr : &frame_data.front(), frame_data.size());
+ MaskWebSocketFramePayload(masking_key, kTests[i].frame_offset,
+ frame_data.empty() ? nullptr : frame_data.data(),
+ frame_data.size());
EXPECT_EQ(expected_output, frame_data);
}
}
